Detect 12V charging and improve ADC recalibration

Author: zorgms

vehicle/OVMS.V3/components/vehicle_smarteq/src/eq_ticker.cpp

@@ -65,6 +65,15 @@ void OvmsVehicleSmartEQ::Ticker10(uint32_t ticker)
 
   if(m_enable_LED_state) 
     OnlineState();
+
+  // check 12V charging state for powermgmt system
+  bool charge_12v = StdMetrics.ms_v_bat_12v_voltage->AsFloat(0.0f) > 13.1f ? true : false;
+  if (charge_12v != StdMetrics.ms_v_env_charging12v->AsBool(false))
+    {
+    StdMetrics.ms_v_env_charging12v->SetValue(charge_12v);    
+    m_ADCfactor_recalc_timer = 2;
+    m_ADCfactor_recalc = charge_12v;
+    }
   }
 
 void OvmsVehicleSmartEQ::Ticker60(uint32_t ticker) {  
@@ -105,30 +114,44 @@ void OvmsVehicleSmartEQ::Ticker60(uint32_t ticker) {
     mt_bus_awake->SetValue(true);
     smartChargeStart();
     }
-  // check 12V charging state for powermgmt system
-  bool charge_12v = StdMetrics.ms_v_bat_12v_voltage->AsFloat(0.0f) > 13.1f ? true : false;
-  if (charge_12v != StdMetrics.ms_v_env_charging12v->AsBool())
-    {
-    StdMetrics.ms_v_env_charging12v->SetValue(charge_12v);
-    }
 
   #ifdef CONFIG_OVMS_COMP_ADC
-  if (m_enable_calcADCfactor && m_ADCfactor_recalc) 
+  if(IsOnEQ() || IsChargingEQ())
     {
-    if (--m_ADCfactor_recalc_timer == 0) 
+    // check for 12V voltage difference between CAN and ADC when the car is rebooted, to detect if ADC factor recalibration is needed
+    if(m_check12vadc)
       {
-      m_ADCfactor_recalc = false;
-      m_ADCfactor_recalc_timer = 4;
-      // calculate new ADC factor      
-      float can12V = mt_evc_dcdc->GetElemValue(1);   // DCDC voltage
-      if (StdMetrics.ms_v_env_charging12v->AsBool(false))
+      float can12V = mt_evc_dcdc->GetElemValue(1);
+      float adc12V = StdMetrics.ms_v_bat_12v_voltage->AsFloat(0.0f);
+      float diff = fabs(can12V - adc12V);
+      bool charging12v = StdMetrics.ms_v_env_charging12v->AsBool(false);
+      if (diff > 0.1f && !m_ADCfactor_recalc && charging12v)      
         {
-        ReCalcADCfactor(can12V, nullptr);  // nullptr = no Log-Output
-        ESP_LOGI(TAG, "Auto ADC recalibration started (%.2fV)", can12V);
-        } 
-      else 
+        ESP_LOGW(TAG, "12V voltage difference detected: CAN=%.2fV, ADC=%.2fV, diff=%.2fV", can12V, adc12V, diff);
+        m_ADCfactor_recalc_timer = 2;   // wait at least 2 min. before recalculation
+        m_enable_calcADCfactor = true;
+        m_ADCfactor_recalc = true;      // recalculate ADC factor when 12V voltage difference detected
+        }
+      m_check12vadc = false;
+      }
+    // if ADC factor recalculation is enabled, then check if it's time to recalculate the factor
+    if (m_enable_calcADCfactor && m_ADCfactor_recalc) 
+      {
+      if (--m_ADCfactor_recalc_timer == 0) 
         {
-        ESP_LOGW(TAG, "Error: Auto ADC recalibration, 12V voltage is not stable for ADC calibration! (%.2fV)", can12V);
+        m_ADCfactor_recalc = false;
+        m_ADCfactor_recalc_timer = 2;
+        // calculate new ADC factor      
+        float can12V = mt_evc_dcdc->GetElemValue(1);   // DCDC voltage
+        if (StdMetrics.ms_v_env_charging12v->AsBool(false))
+          {
+          ReCalcADCfactor(can12V, nullptr);  // nullptr = no Log-Output
+          ESP_LOGI(TAG, "Auto ADC recalibration started (%.2fV)", can12V);
+          } 
+        else 
+          {
+          ESP_LOGW(TAG, "Error: Auto ADC recalibration, 12V voltage is not stable for ADC calibration! (%.2fV)", can12V);
+          }
         }
       }
     }