Fiat eDoblo: add passive lock status#1438
Open
strangesource wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The Fiat e-Doblo / Stellantis EMP2 module did not map the validated passive lock-state frame to the standard OVMS lock metric.
Validated passive signal:
0x6120x02means unlockedv.e.locked = !(d[1] & 0x02)Validated payloads:
612 00 20 01 00 07 fe 00 10612 00 22 01 00 07 fe 00 10Root cause / code path
OvmsVehicleFiatEDoblo::IncomingFrameCan1()is the passive CAN decode path for the FTDO BSI CAN bus. It already decodes related body/status frames such as0x412door state, but had no case for the validated0x612lock-state frame.Fix
Add a
case 0x612passive decode invehicle_fiatedoblo.cppand set:Also update the FTDO user docs and changelog to mention passive lock status.
Validation performed
Runtime validation on an OVMS module configured as FTDO on Citroen e Berlingo
Notes:
0x612; the metric remains the last observed passive CAN state until the BSI wakes and sends the frame.