Fiat eDoblo: add BMS pack temperature polling#1441
Draft
strangesource wants to merge 1 commit into
Draft
Conversation
98089ac to
d404cec
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The FTDO profile already polls BMS min/max cell voltage, HV voltage/current, SOH, and available energy, but standard BMS pack temperature metrics and average cell voltage remain empty.
Reproduction / observation
On the current FTDO vehicle profile, the following standard metrics are present but unset:
A read-only UDS scan against the e-Berlingo BMS while
v.e.on = yesshowed the BMS supports these identifiers via0x6b4 -> 0x694, UDS service0x22:CAN status remained clean after polling: no RX/TX errors, no overflows, no failed TX frames.
Root cause / code path
FTDO BMS diagnostic polling is defined in
vehicle_ftdo_pollsand decoded inOvmsVehicleFiatEDoblo::IncomingBatteryPoll(). The relevant BMS DIDs were simply not included/decoded yet.Fix
Add BMS polling and decoding for:
0xd43d->v.b.p.voltage.avg0xd87d->v.b.p.temp.min0xd817->v.b.p.temp.max0xd877->v.b.p.temp.avgAlso update FTDO docs and change history.
Validation performed
v.e.on = yes.origin/masterbranch: