Skip to content

feat: add bypass support methods to VentilationDevice and corresponding tests#805

Open
norschel wants to merge 5 commits into
openviess:masterfrom
norschel:topics/fs300e_bypass_support
Open

feat: add bypass support methods to VentilationDevice and corresponding tests#805
norschel wants to merge 5 commits into
openviess:masterfrom
norschel:topics/fs300e_bypass_support

Conversation

@norschel

@norschel norschel commented Jul 21, 2026

Copy link
Copy Markdown
Contributor

This pull request adds support for retrieving detailed bypass status information from the ventilation device, along with corresponding unit tests to ensure these new methods work as expected.

New bypass status methods in PyViCareVentilationDevice:

  • Added getBypassActive to check if the bypass is active.
  • Added getBypassPosition to retrieve the current bypass position.
  • Added getBypassAutomaticMode to determine if the bypass is in automatic mode.
  • Added methods to get the bypass operating mode's level, state, and value: getBypassOperatingModeLevel, getBypassOperatingModeState, and getBypassOperatingModeValue.

Test coverage:

  • Added unit tests in tests/test_VitoairFs300E.py for all new bypass status methods to verify correct behavior.This pull request adds support for retrieving the bypass status and configuration from the ventilation device, along with corresponding unit tests to ensure correct functionality.

Ventilation bypass feature support:

  • Added getBypassActive, getBypassPosition, and getBypassAutomaticMode methods to PyViCareVentilationDevice.py to retrieve the bypass's active state, position, and automatic mode status, respectively.

Testing:

  • Introduced unit tests for the new bypass methods (getBypassActive, getBypassPosition, getBypassAutomaticMode) in tests/test_VitoairFs300E.py to verify correct behavior.

Copilot AI review requested due to automatic review settings July 21, 2026 08:26

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Adds new bypass-related accessors to VentilationDevice and introduces unit tests intended to validate those getters against a device response fixture.

Changes:

  • Added getBypassActive(), getBypassPosition(), and getBypassAutomaticMode() to VentilationDevice.
  • Added corresponding unit tests in test_VitoairFs300E.py using a new response fixture name.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.

File Description
PyViCare/PyViCareVentilationDevice.py Adds bypass support getters (active/position/automatic mode) behind @handleNotSupported.
tests/test_VitoairFs300E.py Adds new tests for bypass getters using a referenced JSON fixture.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread tests/test_VitoairFs300E.py Outdated
@norschel
norschel marked this pull request as draft July 21, 2026 08:38
@norschel
norschel marked this pull request as ready for review July 21, 2026 11:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants