feat: add bypass support methods to VentilationDevice and corresponding tests#805
Open
norschel wants to merge 5 commits into
Open
feat: add bypass support methods to VentilationDevice and corresponding tests#805norschel wants to merge 5 commits into
norschel wants to merge 5 commits into
Conversation
There was a problem hiding this comment.
Pull request overview
Adds new bypass-related accessors to VentilationDevice and introduces unit tests intended to validate those getters against a device response fixture.
Changes:
- Added
getBypassActive(),getBypassPosition(), andgetBypassAutomaticMode()toVentilationDevice. - Added corresponding unit tests in
test_VitoairFs300E.pyusing a new response fixture name.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
PyViCare/PyViCareVentilationDevice.py |
Adds bypass support getters (active/position/automatic mode) behind @handleNotSupported. |
tests/test_VitoairFs300E.py |
Adds new tests for bypass getters using a referenced JSON fixture. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
norschel
marked this pull request as draft
July 21, 2026 08:38
norschel
marked this pull request as ready for review
July 21, 2026 11:33
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request adds support for retrieving detailed bypass status information from the ventilation device, along with corresponding unit tests to ensure these new methods work as expected.
New bypass status methods in
PyViCareVentilationDevice:getBypassActiveto check if the bypass is active.getBypassPositionto retrieve the current bypass position.getBypassAutomaticModeto determine if the bypass is in automatic mode.getBypassOperatingModeLevel,getBypassOperatingModeState, andgetBypassOperatingModeValue.Test coverage:
tests/test_VitoairFs300E.pyfor all new bypass status methods to verify correct behavior.This pull request adds support for retrieving the bypass status and configuration from the ventilation device, along with corresponding unit tests to ensure correct functionality.Ventilation bypass feature support:
getBypassActive,getBypassPosition, andgetBypassAutomaticModemethods toPyViCareVentilationDevice.pyto retrieve the bypass's active state, position, and automatic mode status, respectively.Testing:
getBypassActive,getBypassPosition,getBypassAutomaticMode) intests/test_VitoairFs300E.pyto verify correct behavior.