feat: Implements memory-safe temporal VAE slicing within the LTXPipeline#3760
Open
Ashitpatel001 wants to merge 3 commits into
Open
feat: Implements memory-safe temporal VAE slicing within the LTXPipeline#3760Ashitpatel001 wants to merge 3 commits into
Ashitpatel001 wants to merge 3 commits into
Conversation
Author
|
Hi @likholat, I saw you were assigned to this PR a few days ago. Just dropping a gentle ping to see if you might have some bandwidth to review the temporal VAE slicing implementation this week. I am fully available to address any feedback or make architectural adjustments as soon as you are ready. |
Contributor
goyaladitya05
left a comment
There was a problem hiding this comment.
The PR description mentions making changes to the CMake file, but I don't see it in the files changed. Also, in its current state, the test always skips and verifies nothing.
Author
|
Hi @goyaladitya05, thanks for the review!
Let me know how you'd like me to mock the initialization, and I will update the test fixture immediately! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR implements memory-safe temporal VAE slicing within the
LTXPipelineto prevent Out-Of-Memory (OOM) crashes during large video generation tasks. Previously, decoding full latent sequences at once caused massive activation memory spikes in the 3D VAE.Key Implementations:
decode_temporal_slicesdirectly into the monolithicLTXPipelinearchitecture to process latents in manageable chunks (default 32 frames) with a temporal overlap (default 8 frames).blend_temporal_overlapusing OpenVINO'sov::parallel_forto apply a linear cross-fade across overlapping frames. This prevents visual seams without causing CPU bottlenecks.test_text2video_pipeline.cpp) that utilizes the publicText2VideoPipelineAPI to verify anchored stride mathematics and frame alignment. (Note: I am currently updating the mock model initialization based on reviewer feedback so the test executes fully in CI instead of skipping).Fixes #3690
Checklist: