PA LoRA fix#3831
Closed
likholat wants to merge 1 commit into
Closed
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR adjusts ContinuousBatchingPipeline initialization so LoRA adapter configuration is extracted from properties into GenerationConfig.adapters, while passing a filtered properties map downstream (to avoid treating adapter config as generic plugin/model properties).
Changes:
- Add adapter/property extraction helper and include LoRA helper utilities.
- Ensure all ContinuousBatchingPipeline construction paths use “effective” properties with adapters removed.
- Ensure
GenerationConfigpassed to pipeline implementations contains adapters extracted from user properties.
Comment on lines
+58
to
60
| auto generation_config = utils::from_config_json_if_exists(models_path); | ||
| auto effective_properties = extract_non_adapter_properties(properties_without_draft_model, generation_config); | ||
|
|
Comment on lines
+58
to
+59
| auto generation_config = utils::from_config_json_if_exists(models_path); | ||
| auto effective_properties = extract_non_adapter_properties(properties_without_draft_model, generation_config); |
Contributor
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
CVS-186315
Fixes #(issue)
Checklist: