Skip to content

Commit 001443a

Browse files
committed
fix comments: recover int if necessary
1 parent 6189484 commit 001443a

18 files changed

Lines changed: 76 additions & 71 deletions

src/plugins/intel_cpu/CMakeLists.txt

Lines changed: 0 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -8,18 +8,6 @@ endif()
88

99
set(TARGET_NAME "openvino_intel_cpu_plugin")
1010

11-
if(CMAKE_CXX_COMPILER_ID STREQUAL "MSVC")
12-
# C4267, 4244 issues from oneDNN headers conversion from 'XXX' to 'YYY', possible loss of data
13-
ov_add_compiler_flags(/wd4018)
14-
ov_add_compiler_flags(/wd4267)
15-
ov_add_compiler_flags(/wd4244)
16-
# mkldnn headers: '<<': result of 32-bit shift implicitly converted to 64 bits
17-
ov_add_compiler_flags(/wd4334)
18-
# oneDNN arm64: unary minus operator applied to unsigned type, result still unsigned
19-
ov_add_compiler_flags(/wd4146)
20-
elseif (OV_COMPILER_IS_INTEL_LLVM AND WIN32)
21-
ov_add_compiler_flags("/Wno-microsoft-include")
22-
endif()
2311
if(NOT BUILD_SHARED_LIBS)
2412
# Symbols are located in both src and include folders
2513
file(GLOB_RECURSE onednn_files

src/plugins/intel_cpu/src/nodes/ctc_loss.cpp

Lines changed: 11 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -84,9 +84,9 @@ void CTCLoss::execute([[maybe_unused]] const dnnl::stream& strm) {
8484
int32_t returnCode = 0;
8585

8686
const auto* logits = getSrcDataAtPortAs<const float>(0);
87-
const auto* logitsLength = getSrcDataAtPortAs<const int32_t>(1);
88-
const auto* labels = getSrcDataAtPortAs<const int32_t>(2);
89-
const auto* labelsLength = getSrcDataAtPortAs<const int32_t>(3);
87+
const auto* logitsLength = getSrcDataAtPortAs<const int>(1);
88+
const auto* labels = getSrcDataAtPortAs<const int>(2);
89+
const auto* labelsLength = getSrcDataAtPortAs<const int>(3);
9090
auto* dstData = getDstDataAtPortAs<float>(0);
9191

9292
const auto& inDims = getParentEdgeAt(0)->getMemory().getStaticDims();
@@ -99,8 +99,8 @@ void CTCLoss::execute([[maybe_unused]] const dnnl::stream& strm) {
9999
blankIndex = getSrcDataAtPortAs<const int32_t>(4)[0];
100100
}
101101

102-
std::vector<int32_t> decodedTargetLenB(batchNum, 0);
103-
std::vector<std::vector<int32_t>> targetDB(batchNum);
102+
std::vector<int> decodedTargetLenB(batchNum, 0);
103+
std::vector<std::vector<int>> targetDB(batchNum);
104104
std::vector<std::vector<std::vector<float>>> logProbabilitiesB(batchNum);
105105
const auto threads_num = parallel_get_max_threads();
106106
std::vector<std::string> errorMsgB(threads_num);
@@ -268,16 +268,16 @@ void CTCLoss::execute([[maybe_unused]] const dnnl::stream& strm) {
268268
for (size_t b = start; b < end; b++) {
269269
auto& targetD = targetDB[b];
270270
auto& logProbabilities = logProbabilitiesB[b];
271-
const int32_t actualLogitLen = logitsLength[b];
272-
const int32_t decodedTargetLen = decodedTargetLenB[b];
271+
const int actualLogitLen = logitsLength[b];
272+
const int decodedTargetLen = decodedTargetLenB[b];
273273
std::vector<std::vector<float>> logBwd(decodedTargetLen, std::vector<float>(actualLogitLen, -float_inf));
274-
for (int32_t s = decodedTargetLen - 2; s < decodedTargetLen; s++) {
274+
for (int s = decodedTargetLen - 2; s < decodedTargetLen; s++) {
275275
logBwd[s][actualLogitLen - 1] = 0.F;
276276
}
277277

278-
for (int32_t t = actualLogitLen - 2; t >= 0; t--) {
279-
const int32_t t_1 = t + 1;
280-
for (int32_t s = std::max(0, decodedTargetLen - (2 * (actualLogitLen - t)));
278+
for (int t = actualLogitLen - 2; t >= 0; t--) {
279+
const int t_1 = t + 1;
280+
for (int s = std::max(0, decodedTargetLen - (2 * (actualLogitLen - t)));
281281
s < std::min(decodedTargetLen, 2 * (t_1));
282282
s++) {
283283
if (ctcMergeRepeated || targetD[s] == blankIndex) {

src/plugins/intel_cpu/src/nodes/executors/eltwise_stateful_executor.cpp

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -232,15 +232,15 @@ void EltwiseStatefulExecutor::updateExecutionParams(const std::vector<VectorDims
232232
// offsets recalculation
233233
auto offset_out_calc = [](VectorDims& offset, const VectorDims& dims) {
234234
size_t k = 1;
235-
for (int32_t i = static_cast<int32_t>(offset.size()) - 1; i >= 0; i--) {
235+
for (auto i = static_cast<int32_t>(offset.size()) - 1; i >= 0; i--) {
236236
offset[i] = k;
237237
k *= dims[i];
238238
}
239239
};
240240

241241
auto offset_in_calc = [](VectorDims& offset, const VectorDims& inDims, const VectorDims& dims_out) {
242242
size_t k = 1;
243-
for (int32_t i = static_cast<int32_t>(offset.size()) - 1; i >= 0; i--) {
243+
for (auto i = static_cast<int32_t>(offset.size()) - 1; i >= 0; i--) {
244244
offset[i] = (inDims[i] == dims_out[i]) ? k : 0;
245245
k *= inDims[i];
246246
}

src/plugins/intel_cpu/src/nodes/executors/ref/eltwise.cpp

Lines changed: 7 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -372,7 +372,14 @@ void EltwiseRefExecutor<T, Enable>::exec(const jit_eltwise_call_args_ptrs& args_
372372
*dst_ptr_f = src_f[0] || src_f[1];
373373
break;
374374
case Algorithm::EltwiseLogicalXor:
375+
#ifdef _MSC_VER
376+
# pragma warning(push)
377+
# pragma warning(disable : 4244)
378+
#endif
375379
*dst_ptr_f = static_cast<T>((src_f[0] || src_f[1]) - (src_f[0] && src_f[1]));
380+
#ifdef _MSC_VER
381+
# pragma warning(pop)
382+
#endif
376383
break;
377384
case Algorithm::EltwiseLogicalNot:
378385
*dst_ptr_f = !src_f[0];

src/plugins/intel_cpu/src/nodes/executors/transpose.cpp

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -6,6 +6,7 @@
66

77
#include <algorithm>
88
#include <cstddef>
9+
#include <cstdint>
910
#include <iterator>
1011
#include <utility>
1112
#include <vector>
@@ -25,10 +26,10 @@ jit_permute_config_params TransposeExecutor::prepareParams(const PermuteParams&
2526
VectorDims src_block_order = params.src_block_order;
2627
VectorDims src_block_strides(params.src_block_dims.size(), 1);
2728
VectorDims dst_block_strides(params.dst_block_dims.size(), 1);
28-
for (int i = static_cast<int>(params.src_block_dims.size()) - 2; i >= 0; i--) {
29+
for (auto i = static_cast<int32_t>(params.src_block_dims.size()) - 2; i >= 0; i--) {
2930
src_block_strides[i] = src_block_strides[i + 1] * params.src_block_dims[i + 1];
3031
}
31-
for (int i = static_cast<int>(params.dst_block_dims.size()) - 2; i >= 0; i--) {
32+
for (auto i = static_cast<int32_t>(params.dst_block_dims.size()) - 2; i >= 0; i--) {
3233
dst_block_strides[i] = dst_block_strides[i + 1] * params.dst_block_dims[i + 1];
3334
}
3435

@@ -43,7 +44,7 @@ jit_permute_config_params TransposeExecutor::prepareParams(const PermuteParams&
4344
tmp_order.push_back(params.order[params.dst_block_order[i]]);
4445
}
4546

46-
for (int i = static_cast<int>(tmp_order.size()) - 1; i >= 0; i--) {
47+
for (auto i = static_cast<int32_t>(tmp_order.size()) - 1; i >= 0; i--) {
4748
auto pos = std::distance(std::find(src_block_order.rbegin(), src_block_order.rend(), tmp_order[i]),
4849
src_block_order.rend() - 1);
4950
if (pos != -1) {

src/plugins/intel_cpu/src/nodes/if.h

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -56,8 +56,8 @@ class If : public Node {
5656
static std::deque<MemoryPtr> getToMemories(const Node* node, int32_t port);
5757

5858
struct PortMap {
59-
int32_t from; /**< Index of external/internal out data */
60-
int32_t to; /**< Index of external/internal in data */
59+
int from; /**< Index of external/internal out data */
60+
int to; /**< Index of external/internal in data */
6161
};
6262

6363
class PortMapHelper {

src/plugins/intel_cpu/src/nodes/multiclass_nms.cpp

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -517,8 +517,8 @@ void MultiClassNms::nmsWithEta(const float* boxes,
517517
slice_class(batch_idx, class_idx, scores, scoresStrides, false, roisnum, roisnumStrides, shared);
518518

519519
std::priority_queue<boxInfo, std::vector<boxInfo>, decltype(less)> sorted_boxes(less);
520-
int32_t cur_numBoxes = shared ? static_cast<int32_t>(m_numBoxes) : roisnum[batch_idx];
521-
for (int32_t box_idx = 0; box_idx < cur_numBoxes; box_idx++) {
520+
int cur_numBoxes = shared ? static_cast<int>(m_numBoxes) : roisnum[batch_idx];
521+
for (int box_idx = 0; box_idx < cur_numBoxes; box_idx++) {
522522
if (scoresPtr[box_idx] >= m_scoreThreshold) { // algin with ref
523523
sorted_boxes.emplace(boxInfo({scoresPtr[box_idx], box_idx, 0}));
524524
}

src/plugins/intel_cpu/src/nodes/pad.h

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -49,8 +49,8 @@ class Pad : public Node {
4949
float padValue = 0.F;
5050
VectorIdxs padsBegin;
5151
VectorIdxs padsEnd;
52-
int32_t beginPadIdx = 0;
53-
int32_t endPadIdx = 0;
52+
int beginPadIdx = 0;
53+
int endPadIdx = 0;
5454
ov::element::Type prc;
5555
bool constPadValue = false;
5656
std::shared_ptr<CpuParallel> cpuParallel;

src/plugins/intel_cpu/src/nodes/reverse_sequence.cpp

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -62,12 +62,12 @@ ReverseSequence::ReverseSequence(const std::shared_ptr<ov::Node>& op, const Grap
6262

6363
CPU_NODE_ASSERT(dataRank == getOutputShapeAtPort(0).getRank(), "has input/output rank mismatch");
6464

65-
seq_axis = static_cast<int32_t>(revSeq->get_sequence_axis());
65+
seq_axis = static_cast<int>(revSeq->get_sequence_axis());
6666

67-
CPU_NODE_ASSERT(seq_axis >= 0 && seq_axis < static_cast<int32_t>(dataRank),
67+
CPU_NODE_ASSERT(seq_axis >= 0 && seq_axis < static_cast<int>(dataRank),
6868
"has incorrect 'seq_axis' parameters dimensions and axis number!");
6969

70-
batch_axis = static_cast<int32_t>(revSeq->get_batch_axis());
70+
batch_axis = static_cast<int>(revSeq->get_batch_axis());
7171

7272
CPU_NODE_ASSERT(batch_axis >= 0 && batch_axis < static_cast<int>(dataRank),
7373
"has incorrect 'batch_axis' parameters dimensions and axis number!");

src/plugins/intel_cpu/src/nodes/roll.cpp

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -197,9 +197,9 @@ void Roll::RollExecutor::exec(const MemoryPtr& dataMemPtr,
197197
const VectorDims& dataDims = dataMemPtr->getStaticDims();
198198

199199
for (size_t dim = 0; dim < axesLength; ++dim) {
200-
int currentAxis = axes[dim] < 0 ? axes[dim] + static_cast<int>(numOfDims) : axes[dim];
201-
auto shiftSum = static_cast<int>(shiftsVector[currentAxis]) + shift[dim];
202-
auto dimSize = static_cast<int>(dataDims[currentAxis]);
200+
int32_t currentAxis = axes[dim] < 0 ? axes[dim] + static_cast<int32_t>(numOfDims) : axes[dim];
201+
auto shiftSum = static_cast<int32_t>(shiftsVector[currentAxis]) + shift[dim];
202+
auto dimSize = static_cast<int32_t>(dataDims[currentAxis]);
203203
shiftsVector[currentAxis] = (shiftSum % dimSize + dimSize) % dimSize;
204204
}
205205

@@ -220,7 +220,7 @@ void Roll::RollExecutor::exec(const MemoryPtr& dataMemPtr,
220220
size_t leftBlockStartOffset = start;
221221
size_t rightBlockStartOffset = start + leftBlockSize;
222222

223-
for (int32_t dim = static_cast<int32_t>(numOfDims) - 1; dim >= 0; --dim) {
223+
for (auto dim = static_cast<int>(numOfDims) - 1; dim >= 0; --dim) {
224224
leftBlockStartOffset =
225225
calculateShiftOffset(leftBlockStartOffset, shiftsVector[dim], strides[dim], dataDims[dim]);
226226
rightBlockStartOffset =

0 commit comments

Comments
 (0)