Skip to content

[core] Enhance single file storage bounds control#35155

Merged
t-jankowski merged 15 commits intoopenvinotoolkit:masterfrom
t-jankowski:tj/core/sfs-safety-enhancements
Apr 14, 2026
Merged

[core] Enhance single file storage bounds control#35155
t-jankowski merged 15 commits intoopenvinotoolkit:masterfrom
t-jankowski:tj/core/sfs-safety-enhancements

Conversation

@t-jankowski
Copy link
Copy Markdown
Contributor

@t-jankowski t-jankowski commented Apr 3, 2026

Details:

  • Applies overflow and underflow checks in stream manipulations and size/offset calculations.

Tickets:

AI Assistance:

  • AI assistance used: yes
    code completions

@t-jankowski
Keep offset and size values as unsigned
5a78bce 
Signed-off-by: Tomasz Jankowski <tomasz1.jankowski@intel.com>
@t-jankowski
Avoid under and over flows
56f329d 
Signed-off-by: Tomasz Jankowski <tomasz1.jankowski@intel.com>
@t-jankowski
Don't use std::ofstream with ios::in
5b840d6 
Signed-off-by: Tomasz Jankowski <tomasz1.jankowski@intel.com>
@t-jankowski
Write weights only if lock aquires buffer
50646fd 
Signed-off-by: Tomasz Jankowski <tomasz1.jankowski@intel.com>
@t-jankowski t-jankowski requested a review from a team as a code owner April 3, 2026 07:53
@t-jankowski t-jankowski requested review from Copilot and praasz and removed request for a team April 3, 2026 07:53
@github-actions github-actions Bot added the category: inference OpenVINO Runtime library - Inference label Apr 3, 2026
Copilot AI reviewed Apr 3, 2026
View reviewed changes
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot encountered an error and was unable to review this pull request. You can try again by re-requesting a review.

@mlukasze mlukasze requested a review from Copilot April 3, 2026 08:17
Copilot AI reviewed Apr 3, 2026
View reviewed changes
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 3 out of 3 changed files in this pull request and generated 4 comments.

Comment thread src/inference/dev_api/openvino/runtime/single_file_storage.hpp Outdated
Comment thread src/inference/src/single_file_storage.cpp Outdated
Comment thread src/inference/src/single_file_storage.cpp Outdated
Comment thread src/inference/src/dev/tlv_format.cpp
@t-jankowski
Avoid capturing structured bindings
372f5ee 
Signed-off-by: Tomasz Jankowski <tomasz1.jankowski@intel.com>
@t-jankowski
Use precise type
beebcb3 
Signed-off-by: Tomasz Jankowski <tomasz1.jankowski@intel.com>
@t-jankowski
Avoid narrowing conversion
fca18f9 
Signed-off-by: Tomasz Jankowski <tomasz1.jankowski@intel.com>
@t-jankowski t-jankowski requested a review from Copilot April 7, 2026 06:59
Copilot AI reviewed Apr 7, 2026
View reviewed changes
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 3 out of 3 changed files in this pull request and generated 3 comments.

Comment thread src/inference/src/single_file_storage.cpp
Comment thread src/inference/src/dev/tlv_format.cpp
Comment thread src/inference/src/single_file_storage.cpp
@t-jankowski
Merge remote-tracking branch 'upstream/master' into tj/core/sfs-safet…
6034637 
…y-enhancements
@t-jankowski
Fix casting
6c5baa1 
Signed-off-by: Tomasz Jankowski <tomasz1.jankowski@intel.com>
@t-jankowski t-jankowski requested a review from olpipi April 7, 2026 08:38
praasz
praasz reviewed Apr 7, 2026
View reviewed changes
Comment thread src/inference/dev_api/openvino/runtime/single_file_storage.hpp
Comment thread src/inference/src/single_file_storage.cpp Outdated
Comment thread src/inference/src/single_file_storage.cpp Outdated
Comment thread src/inference/src/single_file_storage.cpp
Comment thread src/inference/src/single_file_storage.cpp
Comment thread src/inference/src/single_file_storage.cpp
@t-jankowski
Add test
8671d68 
Signed-off-by: Tomasz Jankowski <tomasz1.jankowski@intel.com>
@praasz praasz added this to the 2026.2 milestone Apr 7, 2026
olpipi
olpipi reviewed Apr 8, 2026
View reviewed changes
Comment thread src/inference/dev_api/openvino/runtime/single_file_storage.hpp
@t-jankowski
Add wrong size test
8974452 
Signed-off-by: Tomasz Jankowski <tomasz1.jankowski@intel.com>
@t-jankowski
Merge remote-tracking branch 'upstream/master' into tj/core/sfs-safet…
82fc38c 
…y-enhancements
@t-jankowski t-jankowski requested review from olpipi and praasz April 10, 2026 11:39
@t-jankowski
Merge remote-tracking branch 'upstream/master' into tj/core/sfs-safet…
74a8fb9 
…y-enhancements
@t-jankowski
Don't pass negative position
b78db61 
Signed-off-by: Tomasz Jankowski <tomasz1.jankowski@intel.com>
@t-jankowski t-jankowski enabled auto-merge April 13, 2026 09:23
@t-jankowski t-jankowski added this pull request to the merge queue Apr 14, 2026
Merged via the queue into openvinotoolkit:master with commit 8948c05 Apr 14, 2026
209 checks passed
sfatimar pushed a commit to sfatimar/openvino that referenced this pull request Apr 23, 2026
@t-jankowski @sfatimar
[core] Enhance single file storage bounds control (openvinotoolkit#35155
41bf475 
)

### Details:
- Applies overflow and underflow checks in stream manipulations and
size/offset calculations.

### Tickets:
 - CVS-183610

### AI Assistance:
 - AI assistance used: yes
   code completions

---------

Signed-off-by: Tomasz Jankowski <tomasz1.jankowski@intel.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Copilot code review Copilot Copilot left review comments

@olpipi olpipi olpipi approved these changes

@praasz praasz praasz approved these changes

Assignees

No one assigned

Labels

category: inference OpenVINO Runtime library - Inference

Projects

None yet

Milestone

2026.2

Development

Successfully merging this pull request may close these issues.

4 participants

@t-jankowski @olpipi @praasz