Skip to content

[CPU][oneDNN] cherry-pick onednn reorder fix#35400

Closed
azhai219 wants to merge 3 commits into
openvinotoolkit:masterfrom
azhai219:az/onednn-cp-reorder
Closed

[CPU][oneDNN] cherry-pick onednn reorder fix#35400
azhai219 wants to merge 3 commits into
openvinotoolkit:masterfrom
azhai219:az/onednn-cp-reorder

Conversation

@azhai219
Copy link
Copy Markdown
Contributor

@azhai219 azhai219 commented Apr 17, 2026

Details:

  • replace onednn revert fix with root fix
  • master has been fixed by reverting. Now, onednn fixed the bug. Let's evaluate whether we need to drop the previous revert and then cherry pick their fix.
  • "onednn pr: cherry pick reorder oneDNN#309"

Tickets:

  • 182686

AI Assistance:

  • AI assistance used: no / yes
  • If yes, summarize how AI was used and what human validation was performed (build/tests/manual checks).

@azhai219 azhai219 requested review from a team as code owners April 17, 2026 07:09
@github-actions github-actions Bot added the category: CPU OpenVINO CPU plugin label Apr 17, 2026
@azhai219 azhai219 requested a review from maxnick April 17, 2026 07:34
Copy link
Copy Markdown
Collaborator

@rkazants rkazants left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

any test on our side what does it fix?

@azhai219
Copy link
Copy Markdown
Contributor Author

any test on our side what does it fix?

It is an onednn kernel selection case. It doesn't make sense of binding some oneDNN verbose because they are always optimizing the kernel. Maybe they can provide better kernel in the next round. If we bind kernel, we may not benefit from them.

@rkazants
Copy link
Copy Markdown
Collaborator

any test on our side what does it fix?

It is an onednn kernel selection case. It doesn't make sense of binding some oneDNN verbose because they are always optimizing the kernel. Maybe they can provide better kernel in the next round. If we bind kernel, we may not benefit from them.

I did not get. If this is functional fix, we should cover this fix by a new test.

@vpirogov
Copy link
Copy Markdown

@rkazants, this PR picks up a proper fix for MFDNN-14804 from oneDNN upstream reducing the delta in the fork. It should not affect OpenVINO functionality or performance.

@maxnick maxnick self-assigned this Apr 21, 2026
@maxnick maxnick added this to the 2026.2 milestone Apr 21, 2026
@azhai219
Copy link
Copy Markdown
Contributor Author

The fix has been verified. Although previous revert #34872 has been merged, we won't merge it.
It won't be an issue in the following integration because onednn fix was merged into main.
close it.

@azhai219 azhai219 closed this Apr 23, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

category: CPU OpenVINO CPU plugin

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants