Skip to content

[core] Add helpers for common operations in mmap tests#36763

Merged
praasz merged 40 commits into
openvinotoolkit:masterfrom
almilosz:almilosz/common-test-util
Jul 10, 2026
Merged

[core] Add helpers for common operations in mmap tests#36763
praasz merged 40 commits into
openvinotoolkit:masterfrom
almilosz:almilosz/common-test-util

Conversation

@almilosz

@almilosz almilosz commented Jul 7, 2026

Copy link
Copy Markdown
Contributor

Details:

  • Reduce code duplication in HintEvictTest, HintPrefetchTest and VmPrefetchMappedFileTest tests
  • Added a new header and implementation (mmap_test_utils.hpp / mmap_test_utils.cpp) providing utility functions: make_prime_pattern() for generating predictable test data, and read_mapped() for extracting bytes from a mapped memory region.
  • Added write_temp_file() in common_test_utils/file_utils.hpp

Tickets:

AI Assistance:

  • AI assistance used: yes

@github-actions github-actions Bot added category: Core OpenVINO Core (aka ngraph) category: IE Tests OpenVINO Test: plugins and common labels Jul 7, 2026
@almilosz almilosz requested a review from praasz July 9, 2026 10:51
Comment thread src/tests/test_utils/common_test_utils/include/common_test_utils/common_utils.hpp Outdated
Comment thread src/tests/test_utils/common_test_utils/include/common_test_utils/common_utils.hpp Outdated
Comment thread src/tests/test_utils/common_test_utils/include/common_test_utils/common_utils.hpp Outdated
Comment thread src/core/tests/mmap_object.cpp Outdated
@praasz praasz added this to the 2026.4 milestone Jul 9, 2026
@praasz praasz self-assigned this Jul 9, 2026
@almilosz almilosz requested review from a team as code owners July 9, 2026 12:23
@almilosz almilosz requested review from mlukasze and removed request for a team July 9, 2026 12:23
@github-actions github-actions Bot added category: CPU OpenVINO CPU plugin no-match-files labels Jul 9, 2026
@almilosz almilosz enabled auto-merge July 9, 2026 12:24
@almilosz almilosz disabled auto-merge July 9, 2026 13:28
@github-actions github-actions Bot removed category: CPU OpenVINO CPU plugin no-match-files labels Jul 9, 2026
@almilosz almilosz enabled auto-merge July 9, 2026 14:09
@almilosz almilosz added this pull request to the merge queue Jul 10, 2026
@praasz praasz removed this pull request from the merge queue due to a manual request Jul 10, 2026
@praasz praasz added this pull request to the merge queue Jul 10, 2026
@github-actions

Copy link
Copy Markdown
Contributor

CI Doctor — Merge Queue failure on this PR

Pipeline: Windows (VS 2022, Python 3.11, Release)
Failure: JS API E2E Electron test cleanup fails with Permission Denied on Windows
Automatic restart: ✅ Re-run of failed jobs requested (reason: Flaky Windows Electron cleanup failure — rm permission denied on locked DLL/exe is transient and a re-run typically succeeds)

Possible remedy

  1. Short-term: The failed jobs have been automatically re-run — no action needed from you.
  2. Long-term fix: Update electron-app.test.js cleanup hook to use fs.rm(path, { recursive: true, force: true }) (Node 14.14+) or the rimraf npm package instead of rm -rf via exec. Windows keeps file locks on electron.exe and its DLLs, which rm cannot bypass.
  3. Ensure the Electron process is fully terminated before cleanup runs (e.g., call app.quit() and wait for process exit before deleting the directory).

What happened

The JS API E2E job on a Windows runner passed its 2 actual tests, but the after all cleanup hook failed when trying to rm -rf demo-electron-app-project — Windows reported Permission denied on locked Electron dist files (electron.exe, d3dcompiler_47.dll, libEGL.dll, libGLESv2.dll). This is unrelated to this PR's changes (mmap test utilities). This exact pattern has been seen 2 times in CI history (previously on 2026-07-09, run 29010970383, PR #36780).

Generated by CI Failure Doctor — Merge Queue · 94.9 AIC · ⌖ 6.47 AIC · ⊞ 17.6K ·

Merged via the queue into openvinotoolkit:master with commit 38e9e0c Jul 10, 2026
220 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

category: Core OpenVINO Core (aka ngraph) category: IE Tests OpenVINO Test: plugins and common

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants