Skip to content

[TEST][DO NOT REVIEW]Master remove cmake glob #36797

Open
DanLiu2Intel wants to merge 8 commits into
openvinotoolkit:masterfrom
DanLiu2Intel:master_removeGLOB_RECURSE
Open

[TEST][DO NOT REVIEW]Master remove cmake glob #36797
DanLiu2Intel wants to merge 8 commits into
openvinotoolkit:masterfrom
DanLiu2Intel:master_removeGLOB_RECURSE

Conversation

@DanLiu2Intel

@DanLiu2Intel DanLiu2Intel commented Jul 9, 2026

Copy link
Copy Markdown
Contributor

Details:

  • Replace file(GLOB_RECURSE) with explicit file list

Tickets:

AI Assistance:

  • AI assistance used: no / yes
  • If yes, summarize how AI was used and what human validation was performed (build/tests/manual checks).

@DanLiu2Intel
DanLiu2Intel requested review from a team as code owners July 9, 2026 09:59
@github-actions github-actions Bot added category: build OpenVINO cmake script / infra category: NPU OpenVINO NPU plugin labels Jul 9, 2026
@DanLiu2Intel
DanLiu2Intel requested a review from Copilot July 9, 2026 10:07

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR replaces file(GLOB...) / file(GLOB_RECURSE...) usage with explicit source lists across Intel NPU plugin/tools CMake files, and introduces a dedicated sources.cmake for the plugin to keep the main CMakeLists.txt readable while still avoiding globbing.

Changes:

  • Replace glob-based source discovery with explicit set(SOURCES ...) file lists in multiple Intel NPU tool/util/library targets.
  • Introduce src/plugins/intel_npu/src/plugin/sources.cmake and update the plugin CMakeLists.txt to include() it, removing globbing for plugin and NPUW sources.
  • Make Intel NPU ops target sources/headers explicitly enumerated.

Reviewed changes

Copilot reviewed 15 out of 15 changed files in this pull request and generated no comments.

Show a summary per file
File Description
src/plugins/intel_npu/tools/single-image-test/cmake/standalone.cmake Replace file(GLOB ...) with an explicit .cpp list for the single-image-test tool target.
src/plugins/intel_npu/tools/protopipe/cmake/standalone.cmake Replace recursive globbing with an explicit main.cpp + src/**.cpp list for the protopipe tool target.
src/plugins/intel_npu/tools/compile_tool/cmake/standalone.cmake Replace file(GLOB ...) with an explicit main.cpp list for the compile tool target.
src/plugins/intel_npu/tools/common/CMakeLists.txt Replace recursive globbing with an explicit list of the common tool utility headers/source.
src/plugins/intel_npu/src/utils/src/zero/CMakeLists.txt Replace recursive globbing with an explicit list of Level Zero utils sources.
src/plugins/intel_npu/src/utils/src/vm/CMakeLists.txt Replace recursive globbing with an explicit list for VM utils sources.
src/plugins/intel_npu/src/utils/src/vcl/CMakeLists.txt Replace recursive globbing with an explicit list for VCL utils sources.
src/plugins/intel_npu/src/utils/src/logger/CMakeLists.txt Replace recursive globbing with an explicit list for logger utils sources.
src/plugins/intel_npu/src/plugin/sources.cmake New file: centralizes explicit SOURCES and NPUW_SOURCES lists for the plugin build.
src/plugins/intel_npu/src/plugin/CMakeLists.txt Switch from globbing to include(sources.cmake) and use ${SOURCES} ${NPUW_SOURCES} in ov_add_plugin().
src/plugins/intel_npu/src/ops/CMakeLists.txt Replace globbing with explicit single source/header for openvino_npu_ops.
src/plugins/intel_npu/src/compiler_adapter/CMakeLists.txt Replace recursive globbing with an explicit list of compiler_adapter headers/sources.
src/plugins/intel_npu/src/common/CMakeLists.txt Replace recursive globbing with an explicit list of common headers/sources.
src/plugins/intel_npu/src/backend/CMakeLists.txt Replace recursive globbing with an explicit list of backend headers/sources.
src/plugins/intel_npu/src/al/CMakeLists.txt Replace recursive globbing with an explicit list of AL headers/sources.

Comment thread src/plugins/intel_npu/src/plugin/sources.cmake Outdated
@DanLiu2Intel
DanLiu2Intel force-pushed the master_removeGLOB_RECURSE branch from a3f28c0 to 8a45f88 Compare July 13, 2026 03:50
@DanLiu2Intel

Copy link
Copy Markdown
Contributor Author

Waiting to rebase and resolve conflicts introduced by the unmerged PR 36099...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

category: build OpenVINO cmake script / infra category: NPU OpenVINO NPU plugin do not merge do_not_merge do_not_review do-not-merge Do not merge this PR

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants