[TEST][DO NOT REVIEW]Master remove cmake glob #36797
Open
DanLiu2Intel wants to merge 8 commits into
Open
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR replaces file(GLOB...) / file(GLOB_RECURSE...) usage with explicit source lists across Intel NPU plugin/tools CMake files, and introduces a dedicated sources.cmake for the plugin to keep the main CMakeLists.txt readable while still avoiding globbing.
Changes:
- Replace glob-based source discovery with explicit
set(SOURCES ...)file lists in multiple Intel NPU tool/util/library targets. - Introduce
src/plugins/intel_npu/src/plugin/sources.cmakeand update the pluginCMakeLists.txttoinclude()it, removing globbing for plugin and NPUW sources. - Make Intel NPU ops target sources/headers explicitly enumerated.
Reviewed changes
Copilot reviewed 15 out of 15 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| src/plugins/intel_npu/tools/single-image-test/cmake/standalone.cmake | Replace file(GLOB ...) with an explicit .cpp list for the single-image-test tool target. |
| src/plugins/intel_npu/tools/protopipe/cmake/standalone.cmake | Replace recursive globbing with an explicit main.cpp + src/**.cpp list for the protopipe tool target. |
| src/plugins/intel_npu/tools/compile_tool/cmake/standalone.cmake | Replace file(GLOB ...) with an explicit main.cpp list for the compile tool target. |
| src/plugins/intel_npu/tools/common/CMakeLists.txt | Replace recursive globbing with an explicit list of the common tool utility headers/source. |
| src/plugins/intel_npu/src/utils/src/zero/CMakeLists.txt | Replace recursive globbing with an explicit list of Level Zero utils sources. |
| src/plugins/intel_npu/src/utils/src/vm/CMakeLists.txt | Replace recursive globbing with an explicit list for VM utils sources. |
| src/plugins/intel_npu/src/utils/src/vcl/CMakeLists.txt | Replace recursive globbing with an explicit list for VCL utils sources. |
| src/plugins/intel_npu/src/utils/src/logger/CMakeLists.txt | Replace recursive globbing with an explicit list for logger utils sources. |
| src/plugins/intel_npu/src/plugin/sources.cmake | New file: centralizes explicit SOURCES and NPUW_SOURCES lists for the plugin build. |
| src/plugins/intel_npu/src/plugin/CMakeLists.txt | Switch from globbing to include(sources.cmake) and use ${SOURCES} ${NPUW_SOURCES} in ov_add_plugin(). |
| src/plugins/intel_npu/src/ops/CMakeLists.txt | Replace globbing with explicit single source/header for openvino_npu_ops. |
| src/plugins/intel_npu/src/compiler_adapter/CMakeLists.txt | Replace recursive globbing with an explicit list of compiler_adapter headers/sources. |
| src/plugins/intel_npu/src/common/CMakeLists.txt | Replace recursive globbing with an explicit list of common headers/sources. |
| src/plugins/intel_npu/src/backend/CMakeLists.txt | Replace recursive globbing with an explicit list of backend headers/sources. |
| src/plugins/intel_npu/src/al/CMakeLists.txt | Replace recursive globbing with an explicit list of AL headers/sources. |
DanLiu2Intel
commented
Jul 10, 2026
DanLiu2Intel
force-pushed
the
master_removeGLOB_RECURSE
branch
from
July 13, 2026 03:50
a3f28c0 to
8a45f88
Compare
Contributor
Author
|
Waiting to rebase and resolve conflicts introduced by the unmerged PR 36099... |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Details:
Tickets:
AI Assistance: