[core] Fix Coverity issues#36819
Open
praasz wants to merge 15 commits into
Open
Conversation
…ed diagnostic pragmas
mitruska
reviewed
Jul 10, 2026
t-jankowski
reviewed
Jul 10, 2026
t-jankowski
approved these changes
Jul 13, 2026
olpipi
approved these changes
Jul 14, 2026
olpipi
left a comment
olpipi
left a comment
Contributor
There was a problem hiding this comment.
I reviewed everything but src/core/tests/constant.cpp
CuriousPanCake
approved these changes
Jul 14, 2026
CuriousPanCake
left a comment
CuriousPanCake
left a comment
Contributor
There was a problem hiding this comment.
No concerns regarding pass code
…west() for improved clarity in range tests
Add LL suffix to integer literals 2147483648 and 2147483649 in in_t_range_i32_ct test suite. MSVC treats decimal literals in range (INT32_MAX, UINT32_MAX] as unsigned int, so applying unary minus to them triggers C4146 (unary minus on unsigned type). Explicit LL suffix forces long long type, eliminating the warning without any pragma.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Details:
Tickets:
AI Assistance: