[TEST][DO NOT REVIEW]#36855
Open
DanLiu2Intel wants to merge 36 commits into
Open
Conversation
…cessary cmake updates
…micarguments fileand remove export npu_vm_runtime_api
…me_api install and export
DanLiu2Intel
added
do not merge
do_not_review
do_not_merge
do-not-merge
github-actions
Bot
added
category: build
Contributor
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 29 out of 29 changed files in this pull request and generated 2 comments.
Comments suppressed due to low confidence (1)
src/plugins/intel_npu/src/utils/src/vm/dynamic_arguments.cpp:73
- [BLOCKER]
MemRefType::set(...)assumestensor->get_strides()is non-empty and has rank entries, then indexesstrides[j]. Elsewhere in the plugin (including this file’s callers)get_strides().empty()is explicitly handled, so this can crash when a tensor reports empty strides.
Fix: handle strides.empty() (treat as contiguous and call updateStride()), and validate strides.size() == _dimsCount before indexing.
Comment on lines
311
to
314
| auto& command_lists = _command_lists.at(i); | ||
| auto& graphArguments = command_lists->getBinding(); | ||
| auto& dynamicArguments = command_lists->getArguments(); | ||
| if (_logger.level() >= ov::log::Level::DEBUG) { | ||
| _logger.debug("push - inputs info for dynamic graph:"); |
Comment on lines
+139
to
+160
| auto assign_slot = [&](MemRefType& slot) { | ||
| slot._basePtr = slot._data = const_cast<void*>(argv); | ||
| if (slot._dimsCount == 0) { | ||
| slot._dimsCount = static_cast<int64_t>(sizes.size()); | ||
| slot._sizes.resize(sizes.size()); | ||
| slot._strides.resize(strides.size()); | ||
| } else if (slot._dimsCount != static_cast<int64_t>(sizes.size())) { | ||
| OPENVINO_THROW("Dimension count mismatch. Current dimension count: ", | ||
| slot._dimsCount, | ||
| ", new dimension count: ", | ||
| sizes.size()); | ||
| } else if (strides.size() != static_cast<size_t>(sizes.size())) { | ||
| OPENVINO_THROW("Updated shape and stride count mismatch: shape rank and stride count differ. Shape rank: ", | ||
| sizes.size(), | ||
| ", stride count: ", | ||
| strides.size()); | ||
| } | ||
| for (int64_t i = 0; i < slot._dimsCount; i++) { | ||
| slot._sizes[i] = static_cast<int64_t>(sizes[i]); | ||
| slot._strides[i] = static_cast<int64_t>(strides[i]); | ||
| } | ||
| }; |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Details:
Tickets:
AI Assistance: