Merge pull request #993 from somiaj/fix-ans-score-hotfix

pstaabp · web-flow · commit 9cefdf9aed09 · 2024-01-24T15:39:15.000-05:00
[Hotfix] Ensure a false score is saved as 0 in AnswerHash.
diff --git a/lib/AnswerHash.pm b/lib/AnswerHash.pm
@@ -252,7 +252,7 @@ sub input {    #$rh_ans->input('foo') is a synonym for $rh_ans->{student_ans}='f
 sub score {
 	my $self  = shift;
 	my $score = shift;
-	$self->{score} = $score if defined($score);
+	$self->{score} = $score || 0 if defined($score);
 	$self->{score};
 }
 
diff --git a/lib/Value/AnswerChecker.pm b/lib/Value/AnswerChecker.pm
@@ -1696,7 +1696,7 @@ sub cmp_list_compare {
 	#
 	#  Check for empty lists
 	#
-	if (scalar(@correct) == 0) { $ans->score($m == 0); return }
+	if (scalar(@correct) == 0) { $ans->score($m == 0 ? 1 : 0); return }
 
 	#
 	#  Loop through student answers looking for correct ones

Original file line number	Diff line number	Diff line change
`@@ -252,7 +252,7 @@ sub input { #$rh_ans->input('foo') is a synonym for $rh_ans->{student_ans}='f`
`252`	`252`	`sub score {`
`253`	`253`	`my $self = shift;`
`254`	`254`	`my $score = shift;`
`255`		`- $self->{score} = $score if defined($score);`
	`255`	`+ $self->{score} = $score \|\| 0 if defined($score);`
`256`	`256`	`$self->{score};`
`257`	`257`	`}`
`258`	`258`
Original file line number	Diff line number	Diff line change
`@@ -1696,7 +1696,7 @@ sub cmp_list_compare {`
`1696`	`1696`	`#`
`1697`	`1697`	`# Check for empty lists`
`1698`	`1698`	`#`
`1699`		`- if (scalar(@correct) == 0) { $ans->score($m == 0); return }`
	`1699`	`+ if (scalar(@correct) == 0) { $ans->score($m == 0 ? 1 : 0); return }`
`1700`	`1700`
`1701`	`1701`	`#`
`1702`	`1702`	`# Loop through student answers looking for correct ones`