typos identified by github.com/crate-ci/typos#1448
Conversation
drgrice1
left a comment
There was a problem hiding this comment.
This is good, but the code changes need to be checked carefully.
|
|
||
| package PolynomialFactors; | ||
| our @ISA = ('LimitedPolynomal'); | ||
| our @ISA = ('LimitedPolynomial'); |
There was a problem hiding this comment.
This change is going to need to be checked. Although the change is to what the original code intended, at this point it makes a change that could cause unexpected behavioral changes. Due to the typo, the PolynomialFactors package effectively had no super class. Fixing the typo makes it so that it does. This means, for instance, that previously calling $f->isa('LimitedPolynomial') where $f is a PolynomialFactors object would have returned false. But with this fixed, it will return true. There are other changes that this will cause as well, such as method resolution for the PolynomialFactors package. These may not matter in this case, but it is worth noting and thinking about.
| @@ -1,4 +1,4 @@ | |||
| BEGIN { strict->import; } | |||
| BeEGIN { strict->import; } | |||
There was a problem hiding this comment.
This is adding a typo! This is a bad one too since it breaks the macro entirely.
This is a massive collection of typo corrections after I used
github.com/crate-ci/typos. Note that it had some false positives, and I examined each one of these to avoid the false positives.Most of these are in code comments and POD.
A small number of these actually correct a meaningful typo in code.
An even smaller number of these correct some typo in a variable or method name. In those cases, I checked that nothing else was relying on the bad variable/method name.