Skip to content

typos identified by github.com/crate-ci/typos#1448

Open
Alex-Jordan wants to merge 1 commit into
openwebwork:PG-2.21from
Alex-Jordan:typos
Open

typos identified by github.com/crate-ci/typos#1448
Alex-Jordan wants to merge 1 commit into
openwebwork:PG-2.21from
Alex-Jordan:typos

Conversation

@Alex-Jordan

Copy link
Copy Markdown
Contributor

This is a massive collection of typo corrections after I used github.com/crate-ci/typos. Note that it had some false positives, and I examined each one of these to avoid the false positives.

Most of these are in code comments and POD.

A small number of these actually correct a meaningful typo in code.

An even smaller number of these correct some typo in a variable or method name. In those cases, I checked that nothing else was relying on the bad variable/method name.

@drgrice1 drgrice1 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is good, but the code changes need to be checked carefully.


package PolynomialFactors;
our @ISA = ('LimitedPolynomal');
our @ISA = ('LimitedPolynomial');

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change is going to need to be checked. Although the change is to what the original code intended, at this point it makes a change that could cause unexpected behavioral changes. Due to the typo, the PolynomialFactors package effectively had no super class. Fixing the typo makes it so that it does. This means, for instance, that previously calling $f->isa('LimitedPolynomial') where $f is a PolynomialFactors object would have returned false. But with this fixed, it will return true. There are other changes that this will cause as well, such as method resolution for the PolynomialFactors package. These may not matter in this case, but it is worth noting and thinking about.

@@ -1,4 +1,4 @@
BEGIN { strict->import; }
BeEGIN { strict->import; }

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is adding a typo! This is a bad one too since it breaks the macro entirely.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants