Merge pull request #3015 from drgrice1/pgeditor-rerender-after-perltidy-failure

somiaj · web-flow · commit 6f377ef4f271 · 2026-06-13T20:51:47.000-06:00
Re-render a problem in the PG problem editor after a perltidy failure.
diff --git a/htdocs/js/PGProblemEditor/pgproblemeditor.js b/htdocs/js/PGProblemEditor/pgproblemeditor.js
@@ -242,11 +242,13 @@
 				}
 				if (request_object.pgCode === data.result_data.tidiedPGCode) {
 					showMessage('There were no changes to the code.', true);
+					if (!(renderArea.firstChild instanceof HTMLIFrameElement)) render();
 				} else {
 					if (webworkConfig?.pgCodeMirror) webworkConfig.pgCodeMirror.source = data.result_data.tidiedPGCode;
 					else document.getElementById('problemContents').value = data.result_data.tidiedPGCode;
 					saveTempFile();
 					showMessage('Successfully perltidied code.', true);
+					if (!(renderArea.firstChild instanceof HTMLIFrameElement)) render();
 				}
 			})
 			.catch((err) => showMessage(`Error: ${err?.message ?? err}`));

Original file line number	Diff line number	Diff line change
`@@ -242,11 +242,13 @@`
`242`	`242`	`}`
`243`	`243`	`if (request_object.pgCode === data.result_data.tidiedPGCode) {`
`244`	`244`	`showMessage('There were no changes to the code.', true);`
	`245`	`+ if (!(renderArea.firstChild instanceof HTMLIFrameElement)) render();`
`245`	`246`	`} else {`
`246`	`247`	`if (webworkConfig?.pgCodeMirror) webworkConfig.pgCodeMirror.source = data.result_data.tidiedPGCode;`
`247`	`248`	`else document.getElementById('problemContents').value = data.result_data.tidiedPGCode;`
`248`	`249`	`saveTempFile();`
`249`	`250`	`showMessage('Successfully perltidied code.', true);`
	`251`	`+ if (!(renderArea.firstChild instanceof HTMLIFrameElement)) render();`
`250`	`252`	`}`
`251`	`253`	`})`
`252`	`254`	.catch((err) => showMessage(`Error: ${err?.message ?? err}`));