Merge pull request #2764 from Alex-Jordan/lis-source-did

record/update user lis_source_did even when grade passback not in use

Author: drgrice1

lib/WeBWorK/Authen/LTIAdvantage.pm

@@ -326,11 +326,9 @@ sub authenticate ($self) {
 		$self->{initial_login} = 1;
 	}
 
-	# If we are using grade passback then make sure the data we need to submit the grade is kept up to date.
-	my $LTIGradeMode = $ce->{LTIGradeMode} // '';
-	if ($LTIGradeMode eq 'course' || $LTIGradeMode eq 'homework') {
-		WeBWorK::Authen::LTIAdvantage::SubmitGrade->new($c)->update_passback_data($self->{user_id});
-	}
+	# In case we will use grade passback at some point,
+	# make sure the data we need to submit the grade is kept up to date.
+	WeBWorK::Authen::LTIAdvantage::SubmitGrade->new($c)->update_passback_data($self->{user_id});
 
 	return 1;
 }

lib/WeBWorK/Authen/LTIAdvantage/SubmitGrade.pm

@@ -70,6 +70,8 @@ sub update_passback_data ($self, $userID) {
 		$self->warning('Missing LMS user id (sub) in JWT.');
 	}
 
+	return unless $ce->{LTIGradeMode};
+
 	# The lti_lms_lineitem is the url to post grades to.  It was the 'lineitem' key of the
 	# 'https://purl.imsglobal.org/spec/lti-ags/claim/endpoint' object in the JWT received from the LMS.
 	if ($ce->{LTIGradeMode} eq 'course') {