Skip to content

Commit ae273f8

Browse files
committed
Make $is_secret optional in ConfigObject::entry_widget.
1 parent 5dbd939 commit ae273f8

8 files changed

Lines changed: 8 additions & 8 deletions

File tree

lib/WeBWorK/ConfigObject.pm

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -55,7 +55,7 @@ sub save_string ($self, $oldval, $use_current = 0) {
5555
}
5656

5757
# A widget to interact with the user
58-
sub entry_widget ($self, $default, $is_secret) {
58+
sub entry_widget ($self, $default, $is_secret = 0) {
5959
return $self->{c}->text_field(
6060
$self->{name} => $is_secret ? SECRET_STRING : $default,
6161
id => $self->{name},

lib/WeBWorK/ConfigObject/boolean.pm

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -29,7 +29,7 @@ sub save_string ($self, $oldval, $use_current = 0) {
2929
return "\$$self->{var} = $newval;\n";
3030
}
3131

32-
sub entry_widget ($self, $default, $is_secret) {
32+
sub entry_widget ($self, $default, $is_secret = 0) {
3333
return $self->{c}->select_field(
3434
$self->{name} => [
3535
[ $self->{c}->maketext('True') => 1, $default == 1 ? (selected => undef) : () ],

lib/WeBWorK/ConfigObject/checkboxlist.pm

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -44,7 +44,7 @@ sub comparison_value ($self, $val) {
4444
return join(',', @{ $val // [] });
4545
}
4646

47-
sub entry_widget ($self, $default, $is_secret) {
47+
sub entry_widget ($self, $default, $is_secret = 0) {
4848
my $c = $self->{c};
4949
return $c->c(
5050
map {

lib/WeBWorK/ConfigObject/list.pm

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -43,7 +43,7 @@ sub save_string ($self, $oldval, $use_current = 0) {
4343
return "\$$self->{var} = [" . join(',', map {"'$_'"} map { $_ =~ s/['"`]//gr } split(',', $newval)) . "];\n";
4444
}
4545

46-
sub entry_widget ($self, $default, $is_secret) {
46+
sub entry_widget ($self, $default, $is_secret = 0) {
4747
my $str = join(', ', @{ $default // [] });
4848
return $self->{c}->text_area(
4949
$self->{name} => $str =~ /\S/ ? $str : '',

lib/WeBWorK/ConfigObject/lms_context_id.pm

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -101,7 +101,7 @@ sub save_string ($self, $oldval, $use_current = 0) {
101101

102102
# This ensures that the input for this setting always shows what is in the database. If the form is submitted, and the
103103
# requested context id is rejected above, then that rejected value should not be shown when the page reloads.
104-
sub entry_widget ($self, $default, $is_secret) {
104+
sub entry_widget ($self, $default, $is_secret = 0) {
105105
$self->{c}->param($self->{name}, $default);
106106
return $self->SUPER::entry_widget($default);
107107
}

lib/WeBWorK/ConfigObject/permission.pm

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -34,7 +34,7 @@ sub save_string ($self, $oldval, $use_current = 0) {
3434
return "\$$self->{var} = '$newval';\n";
3535
}
3636

37-
sub entry_widget ($self, $default, $is_secret) {
37+
sub entry_widget ($self, $default, $is_secret = 0) {
3838
my $c = $self->{c};
3939

4040
# The value of a permission can be undefined (for nobody), a standard permission number, or some other number

lib/WeBWorK/ConfigObject/permission_checkboxlist.pm

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -51,7 +51,7 @@ sub comparison_value ($self, $val) {
5151
return join(',', @{ $val // [] });
5252
}
5353

54-
sub entry_widget ($self, $default, $is_secret) {
54+
sub entry_widget ($self, $default, $is_secret = 0) {
5555
my $c = $self->{c};
5656
$default = role_and_above($self->{c}->ce->{userRoles}, $default) unless ref($default) eq 'ARRAY';
5757
return $c->c(

lib/WeBWorK/ConfigObject/popuplist.pm

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -29,7 +29,7 @@ sub save_string ($self, $oldval, $use_current = 0) {
2929
return ("\$$self->{var} = '$newval';\n");
3030
}
3131

32-
sub entry_widget ($self, $default, $is_secret) {
32+
sub entry_widget ($self, $default, $is_secret = 0) {
3333
my $c = $self->{c};
3434
return $c->select_field(
3535
$self->{name} => [

0 commit comments

Comments
 (0)