Skip to content

LTI 1.1 configure number of digits to round score. #3019

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
somiaj wants to merge 1 commit into
base: WeBWorK-2.21
Choose a base branch
from
+29 −4
Open

LTI 1.1 configure number of digits to round score. #3019

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions conf/authen_LTI.conf.dist
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -240,6 +240,7 @@ $LTIMassUpdateInterval = 86400;
#'LTISendGradesEarlyThreshold',
#'LTIMassUpdateInterval',
#'LMSManageUserData',
#'LTI{v1p1}{round_score_digits}',
#'LTI{v1p1}{BasicConsumerSecret}',
#'LTI{v1p3}{PlatformID}',
#'LTI{v1p3}{ClientID}',
Expand Down
7 changes: 7 additions & 0 deletions conf/authen_LTI_1_1.conf.dist
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,13 @@ $LTI{v1p1}{LMS_name} = 'the LMS';
$LTI{v1p1}{LMS_url} = '';
#$LTI{v1p1}{LMS_url} = 'https://myschool.edu/lms/';

# This sets the number of decimal digits to round the score (a value between 0 and 1) sent to the LMS.
# A setting of 2 means the score is rounded to 2 digits or the nearest whole percent. Setting this to
# a number less than 2 will disable rounding. Note that there maybe some rounding since floats are
# used to compute and save scores in the database and LMS may round the score received.
$LTI{v1p1}{round_score_digits} = 2;
#$LTI{v1p1}{round_score_digits} = 0; # Disable rounding.

################################################################################################
# LTI 1.1 preferred and fallback source of WW user_id
################################################################################################
Expand Down
10 changes: 6 additions & 4 deletions lib/WeBWorK/Authen/LTIAdvanced/SubmitGrade.pm
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -168,11 +168,13 @@ async sub submit_set_grade ($self, $userID, $setID, $submittedSet = undef) {

# Submits a score of $score to the lms with $sourcedid as the identifier.
async sub submit_grade ($self, $sourcedid, $score) {
my $c = $self->{c};
my $ce = $c->{ce};
my $db = $c->{db};
my $c = $self->{c};
my $ce = $c->{ce};
my $db = $c->{db};
my $digits = $ce->{LTI}{v1p1}{round_score_digits} // 2;

$score = wwRound(2, $score);
# Disable rounding unless rounding to two or more digits, which is the nearest whole percent.
$score = wwRound($digits, $score) if $digits > 1;

my $request_url = $db->getSettingValue('lis_outcome_service_url');
if (!$request_url) {
Expand Down
15 changes: 15 additions & 0 deletions lib/WeBWorK/ConfigValues.pm
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1087,6 +1087,21 @@ sub getConfigValues ($ce) {
),
type => 'boolean'
},
'LTI{v1p1}{round_score_digits}' => {
var => 'LTI{v1p1}{round_score_digits}',
doc => x(
'Number of digits to round the score (between 0 and 1) sent to the LMS using LTI 1.1. '
. '(0 => disable rounding)'
),
doc2 => x(
'This sets the number of decimal digits to round the set score (a value between 0 and 1) sent to the '
. 'LMS using LTI 1.1. A setting of 2 means the score is rounded to 2 digits or the nearest whole '
. 'percent. Setting this to a number less than 2 will disable rounding. Note that there maybe '
. 'some rounding since floats are used to compute and save scores in the database and the LMS may '
. 'round the score it recives.'
),
type => 'number'
},
'LTI{v1p1}{BasicConsumerSecret}' => {
var => 'LTI{v1p1}{BasicConsumerSecret}',
doc => x('LMS shared secret for LTI 1.1 authentication'),
Expand Down