[chores] Fixed spelling mistakes and typos #1398

ApurveKaranwal · nemesifier · commit 0518b35e6bdb · 2026-06-16T18:17:46.000-03:00
Closes #1398
diff --git a/openwisp_controller/config/static/config/js/lib/advanced-mode.js b/openwisp_controller/config/static/config/js/lib/advanced-mode.js
@@ -10893,7 +10893,7 @@
 
 						var symbol, preErrorSymbol, state, action, a, r, yyval = {}, p, len, newState, expected;
 						while (true) {
-							// retreive state number from top of stack
+							// retrieve state number from top of stack
 							state = stack[stack.length - 1];
 
 							// use default actions if available
diff --git a/openwisp_controller/config/templates/admin/config/device/change_form.html b/openwisp_controller/config/templates/admin/config/device/change_form.html
@@ -17,7 +17,7 @@
     the change form.
 
     We utilize a distinct form element (id="act_deact_device_form")
-    specifically for these actions. The form attribute of the submit buttons (Acivate/Deactivate)
+    specifically for these actions. The form attribute of the submit buttons (Activate/Deactivate)
     within the submit-row div references this form. By doing so, we ensure that
     these actions can be submitted independently without causing any
     disruption to the device form.
diff --git a/openwisp_controller/config/tests/test_admin.py b/openwisp_controller/config/tests/test_admin.py
@@ -1317,7 +1317,7 @@ def test_variable_usage(self):
 
     def test_preview_device_config_empty_id(self):
         path = reverse(f"admin:{self.app_label}_device_preview")
-        config = json.dumps({"general": {"descripion": "id: {{ id }}"}})
+        config = json.dumps({"general": {"description": "id: {{ id }}"}})
         data = {
             "id": "",
             "name": "test-empty-id",
diff --git a/openwisp_controller/config/tests/test_config.py b/openwisp_controller/config/tests/test_config.py
@@ -111,7 +111,7 @@ def test_backend_openwrt_different_versions(self):
             self.assertIsInstance(c.backend_instance, OpenWrt)
             self.assertEqual(c.backend_instance.dsa, True)
 
-        with self.subTest("DSA disabed OpenWrt Firmware"):
+        with self.subTest("DSA disabled OpenWrt Firmware"):
             c = Config(
                 backend="netjsonconfig.OpenWrt",
                 device=Device(name="test", os="OpenWrt 19.02.2 r16495-bf0c965af0"),
diff --git a/openwisp_controller/config/tests/test_selenium.py b/openwisp_controller/config/tests/test_selenium.py
@@ -280,7 +280,7 @@ def test_change_config_backend(self):
         )
         self.hide_loading_overlay()
         self.find_element(by=By.XPATH, value=f'//*[@value="{template.id}"]')
-        # Change config backed to
+        # Change config backend to
         config_backend_select = Select(
             self.find_element(by=By.NAME, value="config-0-backend")
         )
@@ -302,7 +302,7 @@ def test_force_delete_device_with_deactivating_config(self):
         # The webpage has two "submit-row" sections, each containing a "Deactivate"
         # button. The first (top) "Deactivate" button is hidden, causing
         # `wait_for_visibility` to fail. To avoid this issue, we use
-        # `wait_for='presence'` instead, ensuring we locat the elements regardless
+        # `wait_for='presence'` instead, ensuring we locate the elements regardless
         # of visibility. We then select the last (visible) button and click it.
         self.find_elements(
             by=By.CSS_SELECTOR,
@@ -327,7 +327,7 @@ def test_force_delete_device_with_deactivating_config(self):
             By.CSS_SELECTOR, "#deactivating-warning .messagelist .warning p"
         )
         self.find_element(by=By.CSS_SELECTOR, value="#warning-ack").click()
-        # After accepting the warning, wee need to wait for the animation
+        # After accepting the warning, we need to wait for the animation
         # to complete before trying to interact with the button,
         # otherwise the test may fail due to the button not being fully
         # visible or clickable yet.
@@ -364,7 +364,7 @@ def test_force_delete_multiple_devices_with_deactivating_config(self):
             By.CSS_SELECTOR, "#deactivating-warning .messagelist .warning p"
         )
         self.find_element(by=By.CSS_SELECTOR, value="#warning-ack").click()
-        # After accepting the warning, wee need to wait for the animation
+        # After accepting the warning, we need to wait for the animation
         # to complete before trying to interact with the button,
         # otherwise the test may fail due to the button not being fully
         # visible or clickable yet.
@@ -380,7 +380,7 @@ def test_add_remove_templates(self):
         config = self._create_config(organization=self._get_org())
         device = config.device
         self.login()
-        # some times the url fetching in js gives unauthorized error
+        # sometimes the url fetching in js gives unauthorized error
         # so we add a wait to allow login to complete
         time.sleep(2)
 
diff --git a/openwisp_controller/config/tests/test_views.py b/openwisp_controller/config/tests/test_views.py
@@ -305,7 +305,7 @@ def test_get_default_values_authorization(self):
 
     def test_get_default_values_same_keys(self):
         self._login()
-        # Atleast 4 templates are required to create enough entropy in database
+        # At least 4 templates are required to create enough entropy in database
         # to make the test fail consistently without patch
         template1 = self._create_template(name="VNI 1", default_values={"vn1": "1"})
         template2 = self._create_template(
diff --git a/openwisp_controller/config/whois/tests/tests.py b/openwisp_controller/config/whois/tests/tests.py
@@ -1178,7 +1178,7 @@ class TestWHOISSelenium(CreateWHOISMixin, SeleniumTestMixin, StaticLiveServerTes
     def test_whois_device_admin(self):
         def _assert_no_js_errors():
             browser_logs = []
-            for log in self.get_browser_logs():
+            for log in self.get_browser_logs() or []:
                 if self.browser == "chrome" and log["source"] != "console-api":
                     continue
                 elif log["message"] in ["wrong event specified: touchleave"]:
diff --git a/openwisp_controller/connection/base/models.py b/openwisp_controller/connection/base/models.py
@@ -107,7 +107,7 @@ class AbstractCredentials(ConnectorMixin, ShareableOrgMixinUniqueName, BaseModel
     """
 
     # Controls the number of objects which can be stored in memory
-    # before commiting them to database during bulk auto add operation.
+    # before committing them to database during bulk auto add operation.
     chunk_size = 1000
 
     connector = models.CharField(
@@ -564,7 +564,7 @@ def _save_without_resurrecting(self):
 
     def _schedule_command(self):
         """
-        executes ``launch_command`` celery taks in the background
+        executes ``launch_command`` celery tasks in the background
         once changes are committed to the database
         """
         transaction.on_commit(lambda: launch_command.delay(self.pk))
diff --git a/openwisp_controller/connection/commands.py b/openwisp_controller/connection/commands.py
@@ -58,7 +58,7 @@
                             "title": _("Confirm Password"),
                         },
                     },
-                    "message": _("Your password must be atleast 6 characters long"),
+                    "message": _("Your password must be at least 6 characters long"),
                     "additionalProperties": False,
                     "definitions": {
                         "password_regex": {
diff --git a/openwisp_controller/connection/connectors/openwrt/ssh.py b/openwisp_controller/connection/connectors/openwrt/ssh.py
@@ -11,7 +11,7 @@ class OpenWrt(Ssh):
     def update_config(self):
         try:
             output, exit_code = self.exec_command(
-                # "openwisp_config" for backword compatibility
+                # "openwisp_config" for backward compatibility
                 "(openwisp-config --version || openwisp_config --version) 2>/dev/null"
             )
         except Exception as error:
diff --git a/openwisp_controller/connection/connectors/ssh.py b/openwisp_controller/connection/connectors/ssh.py
@@ -138,7 +138,7 @@ def _connect(self, address):
         """
         Tries to instantiate the SSH connection,
         if the connection fails, it tries again
-        by disabling the new deafult HostKeyAlgorithms
+        by disabling the new default HostKeyAlgorithms
         used by newer versions of Paramiko
         """
         params = self.params
@@ -187,11 +187,11 @@ def exec_command(
         # paramiko expects timeout as a float
         timeout = float(timeout)
         logger.info("Executing command: {0}".format(command))
-        # execute commmand
+        # execute command
         try:
             start_cmd = time.perf_counter()
             stdin, stdout, stderr = self.shell.exec_command(command, timeout=timeout)
-        # re-raise socket.timeout to avoid being catched
+        # re-raise socket.timeout to avoid being caught
         # by the subsequent `except Exception as e` block
         except socket.timeout:
             raise socket.timeout()
diff --git a/openwisp_controller/connection/tests/test_notifications.py b/openwisp_controller/connection/tests/test_notifications.py
@@ -52,7 +52,7 @@ def test_default_notification_type_already_unregistered(self):
         # by some other module
 
         # Unregister "config_error" and "device_registered" notification
-        # types to avoid getting rasing ImproperlyConfigured exceptions
+        # types to avoid getting raising ImproperlyConfigured exceptions
         unregister_notification_type("connection_is_not_working")
         unregister_notification_type("connection_is_working")
 
diff --git a/openwisp_controller/connection/tests/test_selenium.py b/openwisp_controller/connection/tests/test_selenium.py
@@ -55,7 +55,7 @@ def test_command_widget_on_device(self):
         self.find_element(by=By.CSS_SELECTOR, value="#ow-command-confirm-yes").click()
 
         self.assertEqual(Command.objects.count(), 1)
-        # TODO: Selenium tests does not support websocket connections.
+        # TODO: Selenium tests do not support websocket connections.
         # Thus, we need to refresh the page. Remove this when support for
         # websockets is added.
         self.open(path)
diff --git a/openwisp_controller/connection/tests/utils.py b/openwisp_controller/connection/tests/utils.py
@@ -17,7 +17,7 @@ class SshServer(Server):
     def _run(self, *args, **kwargs):
         """
         Hides 'Bad file descriptor' system issue which
-        does not affect the effectivness of the tests
+        does not affect the effectiveness of the tests
         """
         try:
             return super()._run(*args, **kwargs)
diff --git a/openwisp_controller/geo/tests/pytest.py b/openwisp_controller/geo/tests/pytest.py
@@ -160,7 +160,7 @@ async def test_common_location_org_isolation(self):
         connected, _ = await admin_communicator.connect()
         assert connected
 
-        # Updating co-ordinates for org1_location should notify org1_user and admin,
+        # Updating coordinates for org1_location should notify org1_user and admin,
         await self._save_location(str(org1_location.pk))
         org1_response = await org1_communicator.receive_json_from(timeout=1)
         assert org1_response["id"] == str(org1_location.pk)
@@ -181,7 +181,7 @@ async def test_common_location_org_isolation(self):
         connected, _ = await org2_communicator.connect()
         assert connected
 
-        # Updating co-ordinates for org2_location should notify org2_user and admin,
+        # Updating coordinates for org2_location should notify org2_user and admin.
         await self._save_location(str(org2_location.pk))
         org2_response = await org2_communicator.receive_json_from(timeout=1)
         assert org2_response["id"] == str(org2_location.pk)
@@ -190,7 +190,7 @@ async def test_common_location_org_isolation(self):
         with pytest.raises(asyncio.TimeoutError):
             await org1_communicator.receive_json_from(timeout=1)
 
-        # The task is been cancelled if not completed in the given timeout
+        # The task is cancelled if not completed within the given timeout.
         with suppress(asyncio.CancelledError):
             await org1_communicator.disconnect()
             await org2_communicator.disconnect()
diff --git a/openwisp_controller/geo/tests/test_api.py b/openwisp_controller/geo/tests/test_api.py
@@ -185,14 +185,14 @@ def test_deactivated_device(self):
         url = "{0}?key={1}".format(reverse(self.url_name, args=[device.pk]), device.key)
         device.deactivate()
 
-        with self.subTest("Test retrieving device co-ordinates"):
+        with self.subTest("Test retrieving device coordinates"):
             response = self.client.get(
                 url,
                 content_type="application/json",
             )
             self.assertEqual(response.status_code, 200)
 
-        with self.subTest("Test updating device co-ordinates"):
+        with self.subTest("Test updating device coordinates"):
             response = self.client.put(
                 url,
                 content_type="application/json",
diff --git a/openwisp_controller/subnet_division/base/models.py b/openwisp_controller/subnet_division/base/models.py
@@ -132,7 +132,7 @@ def _validate_master_subnet_consistency(self):
             raise ValidationError(
                 {
                     "number_of_subnets": _(
-                        "The master subnet is too small to acommodate the "
+                        "The master subnet is too small to accommodate the "
                         'requested "number of subnets" plus the reserved '
                         "subnet, please increase the size of the master "
                         'subnet or decrease the "size of subnets" field.'
diff --git a/openwisp_controller/subnet_division/rule_types/base.py b/openwisp_controller/subnet_division/rule_types/base.py
@@ -177,7 +177,7 @@ def get_config(cls, instance):
         # check for real existence in DB to workaround
         # this django-import-export bug:
         # https://github.com/django-import-export/django-import-export/issues/1078
-        # TODO: if that issue is ever solved, we can remove the this block below
+        # TODO: if that issue is ever solved, we can remove this block below
         Config = config._meta.model
         if not Config.objects.filter(pk=config.pk).exists():
             raise ObjectDoesNotExist()
diff --git a/openwisp_controller/subnet_division/tests/test_models.py b/openwisp_controller/subnet_division/tests/test_models.py
@@ -178,7 +178,7 @@ def test_field_validations(self):
                 rule.full_clean()
             expected_message_dict = {
                 "number_of_subnets": [
-                    "The master subnet is too small to acommodate "
+                    "The master subnet is too small to accommodate "
                     'the requested "number of subnets" plus the '
                     "reserved subnet, please increase the size of "
                     "the master subnet or decrease the "
@@ -279,7 +279,7 @@ def test_slash_32_rule_ipv4_error(self):
         except ValidationError as e:
             self.assertIn("number_of_subnets", e.message_dict)
             self.assertIn(
-                "The master subnet is too small to acommodate",
+                "The master subnet is too small to accommodate",
                 e.message_dict["number_of_subnets"][0],
             )
         else:
@@ -315,7 +315,7 @@ def test_slash_128_rule_ipv6_error(self):
         except ValidationError as e:
             self.assertIn("number_of_subnets", e.message_dict)
             self.assertIn(
-                "The master subnet is too small to acommodate",
+                "The master subnet is too small to accommodate",
                 e.message_dict["number_of_subnets"][0],
             )
         else:
@@ -495,7 +495,7 @@ def test_subnets_exhausted(self, mocked_logger, *args):
         subnet = self._get_master_subnet(
             "10.0.0.0/29", master_subnet=self.master_subnet
         )
-        # The master subnet can acommodate
+        # The master subnet can accommodate
         # this rule only once:
         # A /29 has 4 /31 slots available
         # Minus the reserved subnet = 3

Original file line number	Diff line number	Diff line change
`@@ -11,7 +11,7 @@ class OpenWrt(Ssh):`
`11`	`11`	`def update_config(self):`
`12`	`12`	`try:`
`13`	`13`	`output, exit_code = self.exec_command(`
`14`		`- # "openwisp_config" for backword compatibility`
	`14`	`+ # "openwisp_config" for backward compatibility`
`15`	`15`	`"(openwisp-config --version \|\| openwisp_config --version) 2>/dev/null"`
`16`	`16`	`)`
`17`	`17`	`except Exception as error:`