[chores:fix] Allow enabling estimated location only if whois enabled

Author: nemesifier

openwisp_controller/geo/base/models.py

@@ -11,7 +11,7 @@
 )
 from swapper import get_model_name
 
-from openwisp_controller.config import settings as config_settings
+from openwisp_controller.config import settings as config_app_settings
 from openwisp_controller.geo import settings as geo_settings
 from openwisp_controller.geo.estimated_location.service import EstimatedLocationService
 from openwisp_users.mixins import OrgMixin, ValidateOrgMixin
@@ -185,7 +185,7 @@ def __str__(self):
         }
 
     def clean(self):
-        if not config_settings.WHOIS_CONFIGURED and self.estimated_location_enabled:
+        if not config_app_settings.WHOIS_CONFIGURED and self.estimated_location_enabled:
             raise ValidationError(
                 {
                     "estimated_location_enabled": _(
@@ -194,6 +194,20 @@ def clean(self):
                     )
                 }
             )
+        config_settings = getattr(self.organization, "config_settings", None)
+        if (
+            config_settings
+            and not config_settings.whois_enabled
+            and self.estimated_location_enabled
+        ):
+            raise ValidationError(
+                {
+                    "estimated_location_enabled": _(
+                        "The WHOIS feature must be enabled for this organization "
+                        "before enabling the Estimated Location feature."
+                    )
+                }
+            )
 
     @classmethod
     def organization_post_save_receiver(cls, sender, instance, created, **kwargs):

openwisp_controller/geo/estimated_location/tests/tests.py

@@ -115,6 +115,20 @@ def test_organization_geo_settings_validation(self):
             # Should not raise
             geo_settings.full_clean()
 
+        with self.subTest(
+            "Estimated location cannot be enabled when WHOIS is disabled for the org"
+        ):
+            org.config_settings.whois_enabled = False
+            org.config_settings.save()
+            geo_settings = org.geo_settings
+            geo_settings.estimated_location_enabled = True
+            with self.assertRaises(ValidationError) as context_manager:
+                geo_settings.full_clean()
+            self.assertIn(
+                "estimated_location_enabled",
+                context_manager.exception.message_dict,
+            )
+
     location_model = Location
 
     def test_estimated_location_field(self):