[Improvement] Added timeout to request.post #1049

Added timeout parameter to request.post with verify variable
simplification. Guard against missing action parameter to prevent AttributeError.

Fixes #1049

Author: stktyagi

openwisp_controller/config/tasks.py

@@ -137,7 +137,8 @@ def trigger_vpn_server_endpoint(endpoint, auth_token, vpn_id):
         response = requests.post(
             endpoint,
             params={"key": auth_token},
-            verify=False if getattr(settings, "DEBUG") else True,
+            verify=not settings.DEBUG,
+            timeout=30,
         )
         response.raise_for_status()
     except requests.RequestException as e:

openwisp_controller/config/utils.py

@@ -213,7 +213,7 @@ def get_config_error_notification_target_url(obj, field, absolute_url=True):
 
 def send_api_task_notification(type, **kwargs):
     vpn = kwargs.get("instance")
-    action = kwargs.get("action").replace("_", " ")
+    action = kwargs.get("action", "").replace("_", " ")
     exception = kwargs.get("exception")
     # Adding some delay here to prevent overlapping
     # of the django success message container