Skip to content

[docs] Port changelog for release 1.2.3#1333

Merged
nemesifier merged 1 commit intomasterfrom
chore/port-changelog-1.2.3
Apr 9, 2026
Merged

[docs] Port changelog for release 1.2.3#1333
nemesifier merged 1 commit intomasterfrom
chore/port-changelog-1.2.3

Conversation

@nemesifier
Copy link
Copy Markdown
Member

Note: This PR was automatically generated by the openwisp-utils releaser tool.

@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai bot commented Apr 9, 2026

📝 Walkthrough

Walkthrough

A changelog entry was added for Version 1.2.3, documenting four bugfixes: initial field value assignment in the AbstractDevice class, duplicate template entries in Device admin, Config checksum invalidation after subnet provisioning, and concurrent update_config detection handling.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

🚥 Pre-merge checks | ✅ 2 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Description check ⚠️ Warning The description is minimal and lacks most required template sections including checklist items, issue reference, and detailed description of changes. Complete the PR description template by adding the checklist items, reference to related issue(s), and a detailed description of the changelog entries being ported.
✅ Passed checks (2 passed)
Check name Status Explanation
Title check ✅ Passed The title '[docs] Port changelog for release 1.2.3' follows the required format with [docs] type prefix and clearly describes the main change: porting the changelog for version 1.2.3.
Bug Fixes ✅ Passed This pull request is a documentation-only update to CHANGES.rst that records previously-implemented bugfixes. It contains no code changes to core functionality, so the custom check's applicability condition is not satisfied.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch chore/port-changelog-1.2.3

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@kilo-code-bot
Copy link
Copy Markdown

kilo-code-bot bot commented Apr 9, 2026

Code Review Summary

Status: No Issues Found | Recommendation: Merge

Files Reviewed (1 file)
  • CHANGES.rst - Documentation-only change adding changelog entries for version 1.2.3

This PR correctly ports the changelog for release 1.2.3. The entries follow the existing format and include:

  • Version header with release date (2026-04-09)
  • Bugfixes section with 4 resolved issues
  • Proper RST formatting and issue links

Reviewed by kimi-k2.5 · 81,744 tokens

Copy link
Copy Markdown
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.

Inline comments:
In `@CHANGES.rst`:
- Line 17: Change the changelog entry to past tense and format the model name
consistently: replace "Invalidate Config checksum after subnet provisioning"
with a past-tense phrase such as "Invalidated ``Config`` checksum after subnet
provisioning" or follow the project pattern like "Fixed Config checksum
invalidation after subnet provisioning"; ensure ``Config`` is wrapped in double
backticks to match how ``AbstractDevice`` and ``update_config`` are formatted
elsewhere.
🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

  • Push a commit to this branch (recommended)
  • Create a new PR with the fixes

ℹ️ Review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: ASSERTIVE

Plan: Pro

Run ID: b8e0a48b-65da-4ee9-ab79-137160f18304

📥 Commits

Reviewing files that changed from the base of the PR and between b8c4d3c and 82e8400.

📒 Files selected for processing (1)
  • CHANGES.rst
📜 Review details
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (4)
  • GitHub Check: Python==3.10 | django~=5.1.0
  • GitHub Check: Python==3.11 | django~=4.2.0
  • GitHub Check: Python==3.11 | django~=5.1.0
  • GitHub Check: Analyze (javascript-typescript)


- Corrected initial field value assignment in ``AbstractDevice`` class
- Fixed duplicate template entries in Device admin
- Invalidate Config checksum after subnet provisioning
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🧹 Nitpick | 🔵 Trivial

Use past tense for consistency with other changelog entries.

The entry "Invalidate Config checksum after subnet provisioning" uses present tense ("Invalidate"), which is inconsistent with all other changelog entries that use past tense verbs (e.g., "Fixed", "Corrected", "Added"). Additionally, consider wrapping Config in double backticks since it appears to be a model/class name, consistent with how AbstractDevice and update_config are formatted in other entries.

📝 Suggested revision for consistency
-- Invalidate Config checksum after subnet provisioning
+- Invalidated ``Config`` checksum after subnet provisioning

Or alternatively, to match the "Fixed X" pattern used in other entries:

-- Invalidate Config checksum after subnet provisioning
+- Fixed ``Config`` checksum not being invalidated after subnet provisioning
📝 Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.

Suggested change
- Invalidate Config checksum after subnet provisioning
- Invalidated ``Config`` checksum after subnet provisioning
Suggested change
- Invalidate Config checksum after subnet provisioning
- Fixed ``Config`` checksum not being invalidated after subnet provisioning
🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed.

In `@CHANGES.rst` at line 17, Change the changelog entry to past tense and format
the model name consistently: replace "Invalidate Config checksum after subnet
provisioning" with a past-tense phrase such as "Invalidated ``Config`` checksum
after subnet provisioning" or follow the project pattern like "Fixed Config
checksum invalidation after subnet provisioning"; ensure ``Config`` is wrapped
in double backticks to match how ``AbstractDevice`` and ``update_config`` are
formatted elsewhere.

@coveralls
Copy link
Copy Markdown

Coverage Status

coverage: 98.588%. remained the same — chore/port-changelog-1.2.3 into master

@nemesifier nemesifier merged commit d49f9bf into master Apr 9, 2026
22 checks passed
@nemesifier nemesifier deleted the chore/port-changelog-1.2.3 branch April 9, 2026 18:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants