Skip to content
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 12 additions & 0 deletions CHANGES.rst
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,18 @@ Version 1.3.0 [unreleased]

Work in progress.

Version 1.2.3 [2026-04-09]
--------------------------

Bugfixes
~~~~~~~~

- Corrected initial field value assignment in ``AbstractDevice`` class
- Fixed duplicate template entries in Device admin
- Invalidate Config checksum after subnet provisioning
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🧹 Nitpick | 🔵 Trivial

Use past tense for consistency with other changelog entries.

The entry "Invalidate Config checksum after subnet provisioning" uses present tense ("Invalidate"), which is inconsistent with all other changelog entries that use past tense verbs (e.g., "Fixed", "Corrected", "Added"). Additionally, consider wrapping Config in double backticks since it appears to be a model/class name, consistent with how AbstractDevice and update_config are formatted in other entries.

📝 Suggested revision for consistency
-- Invalidate Config checksum after subnet provisioning
+- Invalidated ``Config`` checksum after subnet provisioning

Or alternatively, to match the "Fixed X" pattern used in other entries:

-- Invalidate Config checksum after subnet provisioning
+- Fixed ``Config`` checksum not being invalidated after subnet provisioning
📝 Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.

Suggested change
- Invalidate Config checksum after subnet provisioning
- Invalidated ``Config`` checksum after subnet provisioning
Suggested change
- Invalidate Config checksum after subnet provisioning
- Fixed ``Config`` checksum not being invalidated after subnet provisioning
🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed.

In `@CHANGES.rst` at line 17, Change the changelog entry to past tense and format
the model name consistently: replace "Invalidate Config checksum after subnet
provisioning" with a past-tense phrase such as "Invalidated ``Config`` checksum
after subnet provisioning" or follow the project pattern like "Fixed Config
checksum invalidation after subnet provisioning"; ensure ``Config`` is wrapped
in double backticks to match how ``AbstractDevice`` and ``update_config`` are
formatted elsewhere.

- Fixed concurrent ``update_config`` detection `#1204
<https://github.com/openwisp/openwisp-controller/issues/1204>`_

Version 1.2.2 [2026-03-06]
--------------------------

Expand Down
Loading