[tests] Add missing sample_config admin tests on master#996
Merged
nemesifier merged 5 commits intoApr 10, 2025
Merged
Conversation
asmodehn
changed the title
asmodehn
changed the title
Member
Author
|
Note : This is the same as #995, but on master branch. This one has one more commit, fixing a test. |
nemesifier
reviewed
Apr 10, 2025
Member
nemesifier
left a comment
nemesifier
left a comment
There was a problem hiding this comment.
The test test_device_with_config_change_deactivate_deactivate is failing due to the presence of 1 more readonly field than expected. Hey @pandafy, any idea of why this is happening?
nemesifier
previously approved these changes
Apr 10, 2025
Member
nemesifier
left a comment
nemesifier
left a comment
There was a problem hiding this comment.
I pushed a fix, waiting for the build.
+ reformatted code
nemesifier
force-pushed
the
add_missing_sample_config_tests_on_master
branch
from
5d9b672 to
4330144
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist
Description of Changes
This PR adds tests that seemed to be missing among the sample_config tests