[fix] Add tests for user credentials data migration

Author: Eeshu-Yadav

openwisp_radius/migrations/0043_alter_organizationradiussettings_sms_meta_data_and_more.py

@@ -1,5 +1,6 @@
 # Generated by Django 5.2.5 on 2025-10-22 18:34
 
+import django.core.serializers.json
 from django.db import migrations, models
 
 
@@ -15,6 +16,7 @@ class Migration(migrations.Migration):
             name="sms_meta_data",
             field=models.JSONField(
                 blank=True,
+                encoder=django.core.serializers.json.DjangoJSONEncoder,
                 help_text=(
                     "Additional configuration for SMS backend in JSON format "
                     "(optional, leave blank if unsure)"
@@ -26,6 +28,11 @@ class Migration(migrations.Migration):
         migrations.AlterField(
             model_name="radiusbatch",
             name="user_credentials",
-            field=models.JSONField(blank=True, null=True, verbose_name="PDF"),
+            field=models.JSONField(
+                blank=True,
+                encoder=django.core.serializers.json.DjangoJSONEncoder,
+                null=True,
+                verbose_name="PDF",
+            ),
         ),
     ]

openwisp_radius/migrations/0044_convert_user_credentials_data.py

@@ -3,8 +3,7 @@
 import json
 import logging
 
-import django.core.serializers.json
-from django.db import migrations, models
+from django.db import migrations
 
 logger = logging.getLogger(__name__)
 
@@ -40,30 +39,6 @@ class Migration(migrations.Migration):
     ]
 
     operations = [
-        migrations.AlterField(
-            model_name="organizationradiussettings",
-            name="sms_meta_data",
-            field=models.JSONField(
-                blank=True,
-                encoder=django.core.serializers.json.DjangoJSONEncoder,
-                help_text=(
-                    "Additional configuration for SMS backend in JSON format "
-                    "(optional, leave blank if unsure)"
-                ),
-                null=True,
-                verbose_name="SMS meta data",
-            ),
-        ),
-        migrations.AlterField(
-            model_name="radiusbatch",
-            name="user_credentials",
-            field=models.JSONField(
-                blank=True,
-                encoder=django.core.serializers.json.DjangoJSONEncoder,
-                null=True,
-                verbose_name="PDF",
-            ),
-        ),
         migrations.RunPython(
             convert_user_credentials_data, reverse_code=migrations.RunPython.noop
         ),

openwisp_radius/tests/test_migrations.py

@@ -0,0 +1,62 @@
+import importlib
+import json
+from unittest.mock import MagicMock
+
+from django.db import connection
+from django.test import TestCase
+
+from openwisp_radius.models import RadiusBatch
+from openwisp_users.tests.utils import TestOrganizationMixin
+
+migration_module = importlib.import_module(
+    "openwisp_radius.migrations.0044_convert_user_credentials_data"
+)
+convert_user_credentials_data = migration_module.convert_user_credentials_data
+
+
+class Test0044Migration(TestOrganizationMixin, TestCase):
+    def test_convert_user_credentials_data(self):
+        org = self._get_org()
+        batch = RadiusBatch.objects.create(
+            name="test_batch_migration",
+            strategy="prefix",
+            prefix="test",
+            organization=org,
+        )
+        RadiusBatch.objects.filter(pk=batch.pk).update(
+            user_credentials=json.dumps({"user1": "pass1"})
+        )
+
+        apps = MagicMock()
+        apps.get_model.return_value = RadiusBatch
+
+        schema_editor = MagicMock()
+        schema_editor.connection = connection
+
+        convert_user_credentials_data(apps, schema_editor)
+
+        batch.refresh_from_db()
+        self.assertEqual(batch.user_credentials, {"user1": "pass1"})
+
+    def test_convert_user_credentials_data_invalid_json(self):
+        org = self._get_org()
+        batch = RadiusBatch.objects.create(
+            name="test_batch_invalid",
+            strategy="prefix",
+            prefix="test2",
+            organization=org,
+        )
+        RadiusBatch.objects.filter(pk=batch.pk).update(
+            user_credentials="invalid_json_string"
+        )
+
+        apps = MagicMock()
+        apps.get_model.return_value = RadiusBatch
+
+        schema_editor = MagicMock()
+        schema_editor.connection = connection
+
+        convert_user_credentials_data(apps, schema_editor)
+
+        batch.refresh_from_db()
+        self.assertEqual(batch.user_credentials, "invalid_json_string")