Merge branch 'master' into fix/readonlyadmin-cascade-delete

Author: UltraBot05

.github/actions/bot-ci-failure/analyze_failure.py

@@ -9,7 +9,6 @@
 # Strict markers that unequivocally indicate a failing test or assertion.
 STRICT_TEST_FAILURE_MARKERS = (
     "FAIL:",
-    "FAILED (",
     "AssertionError",
 )
 
@@ -35,6 +34,7 @@
     "Network is unreachable",
     "Temporary failure in name resolution",
     "selenium.common.exceptions.InvalidSessionIdException",
+    "selenium.common.exceptions.WebDriverException",
     "Posting coverage data to https://coveralls.io",
     "OperationalError: database is locked",
     "ERROR: Could not install packages due to an OSError",

.github/actions/bot-ci-failure/test_analyze_failure.py

@@ -338,6 +338,20 @@ def test_transient_marker_containing_error_keyword(self):
         self.assertTrue(transient_only)
         self.assertFalse(tests_failed)
 
+    def test_transient_ignores_unittest_failed_summary(self):
+        """Ensure unittest's 'FAILED (errors=1)' summary does not override transient crashes."""
+        content = (
+            "===== JOB 5 =====\n"
+            "Traceback (most recent call last):\n"
+            "selenium.common.exceptions.WebDriverException: Message: Reached error page: about:neterror\n"
+            "----------------------------------------------------------------------\n"
+            "Ran 367 tests in 311.148s\n\n"
+            "FAILED (errors=1)\n"
+        )
+        text, tests_failed, transient_only = process_error_logs(content)
+        self.assertFalse(tests_failed)
+        self.assertTrue(transient_only)
+
 
 class TestNormalizeForDedup(unittest.TestCase):
     """Tests for _normalize_for_dedup."""

docs/developer/reusable-github-utils.rst

@@ -491,10 +491,15 @@ to secrets, and is the one that generates and posts the changelog comment.
 To enable the changelog bot in any OpenWISP repository, create the
 following two workflow files.
 
-**1. Trigger** (``.github/workflows/bot-changelog-trigger.yml``)
+To enable the changelog bot in any OpenWISP repository, create the
+following two workflow files under ``.github/workflows/``.
+
+The trigger workflow runs when a PR review is submitted. If the PR is
+approved by a maintainer and its title starts with ``[feature]``,
+``[fix]``, or ``[change]``, it stores the PR number as workflow metadata.
 
-This workflow fires on PR approval, checks if the PR is noteworthy, and
-uploads the PR number as an artifact for the runner to pick up.
+**1. Changelog Bot Trigger**
+(``.github/workflows/bot-changelog-trigger.yml``)
 
 .. code-block:: yaml
 
@@ -504,6 +509,8 @@ uploads the PR number as an artifact for the runner to pick up.
       pull_request_review:
         types: [submitted]
 
+    permissions: {}
+
     jobs:
       check:
         if: |
@@ -530,15 +537,16 @@ uploads the PR number as an artifact for the runner to pick up.
 
           - name: Upload PR metadata
             if: steps.check.outputs.has_noteworthy == 'true'
-            uses: actions/upload-artifact@v4
+            uses: actions/upload-artifact@v7
             with:
               name: changelog-metadata
               path: pr_number
 
-**2. Runner** (``.github/workflows/bot-changelog-runner.yml``)
+The runner workflow is triggered after the trigger workflow completes. It
+retrieves the PR metadata and calls the reusable changelog workflow.
 
-This workflow triggers after the trigger completes, downloads the
-artifact, and calls the reusable workflow with full secret access.
+**2. Changelog Bot Runner**
+(``.github/workflows/bot-changelog-runner.yml``)
 
 .. code-block:: yaml
 
@@ -552,20 +560,19 @@ artifact, and calls the reusable workflow with full secret access.
 
     permissions:
       actions: read
-      contents: read
-      pull-requests: write
-      issues: write
 
     jobs:
       fetch-metadata:
         runs-on: ubuntu-latest
         if: github.event.workflow_run.conclusion == 'success'
+        permissions:
+          actions: read
         outputs:
           pr_number: ${{ steps.metadata.outputs.pr_number }}
         steps:
           - name: Download PR metadata
             id: download
-            uses: actions/download-artifact@v4
+            uses: actions/download-artifact@v8
             with:
               name: changelog-metadata
               github-token: ${{ secrets.GITHUB_TOKEN }}
@@ -586,6 +593,10 @@ artifact, and calls the reusable workflow with full secret access.
       changelog:
         needs: fetch-metadata
         if: needs.fetch-metadata.outputs.pr_number != ''
+        permissions:
+          contents: read
+          pull-requests: write
+          issues: write
         uses: openwisp/openwisp-utils/.github/workflows/reusable-bot-changelog.yml@master
         with:
           pr_number: ${{ needs.fetch-metadata.outputs.pr_number }}

setup.py

@@ -38,7 +38,7 @@
     zip_safe=False,
     install_requires=[
         "django-model-utils>=4.5,<5.1",
-        "django-minify-compress-staticfiles~=1.1.0",
+        "django-minify-compress-staticfiles~=1.1.1",
         "django-admin-autocomplete-filter~=0.7.1",
         "swapper~=1.4.0",
         # allow wider range here to avoid interfering with other modules