Skip to content

Commit 83ac9fc

Browse files
authored
[chores:fix] Removed 'FAILED (' from strict markers to unblock auto-retry
1 parent 03e4717 commit 83ac9fc

2 files changed

Lines changed: 15 additions & 1 deletion

File tree

.github/actions/bot-ci-failure/analyze_failure.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,6 @@
99
# Strict markers that unequivocally indicate a failing test or assertion.
1010
STRICT_TEST_FAILURE_MARKERS = (
1111
"FAIL:",
12-
"FAILED (",
1312
"AssertionError",
1413
)
1514

@@ -35,6 +34,7 @@
3534
"Network is unreachable",
3635
"Temporary failure in name resolution",
3736
"selenium.common.exceptions.InvalidSessionIdException",
37+
"selenium.common.exceptions.WebDriverException",
3838
"Posting coverage data to https://coveralls.io",
3939
"OperationalError: database is locked",
4040
"ERROR: Could not install packages due to an OSError",

.github/actions/bot-ci-failure/test_analyze_failure.py

Lines changed: 14 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -338,6 +338,20 @@ def test_transient_marker_containing_error_keyword(self):
338338
self.assertTrue(transient_only)
339339
self.assertFalse(tests_failed)
340340

341+
def test_transient_ignores_unittest_failed_summary(self):
342+
"""Ensure unittest's 'FAILED (errors=1)' summary does not override transient crashes."""
343+
content = (
344+
"===== JOB 5 =====\n"
345+
"Traceback (most recent call last):\n"
346+
"selenium.common.exceptions.WebDriverException: Message: Reached error page: about:neterror\n"
347+
"----------------------------------------------------------------------\n"
348+
"Ran 367 tests in 311.148s\n\n"
349+
"FAILED (errors=1)\n"
350+
)
351+
text, tests_failed, transient_only = process_error_logs(content)
352+
self.assertFalse(tests_failed)
353+
self.assertTrue(transient_only)
354+
341355

342356
class TestNormalizeForDedup(unittest.TestCase):
343357
"""Tests for _normalize_for_dedup."""

0 commit comments

Comments
 (0)