luci-app-openvpn: add translation for OpenVPN config name option#8578
Conversation
4df2843 to
c2a0ce7
Compare
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
c2a0ce7 to
29fffd9
Compare
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
60d5da8 to
a7f9859
Compare
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
|
Hi @lorthirk Any chance you can fix the failed checks so it might get merged ? Thanks in advance. |
|
Hey @hagaygo I can sure fix the first two warnings, but I'm not really sure what do I have to do for the third one. The original file does not exist in |
fix: name column not showing in configurations table. following comments at openwrt/openwrt#21746 (comment) Fixes openwrt/openwrt#21746 Signed-off-by: Claudio Mezzasalma <claudio.mezzasalma@gmail.com>
a7f9859 to
e7f631d
Compare
|
I am not sure myself. I assume it means |
|
I know what a cherry-pick is, but in order for me to cherry-pick the commit I should merge my changes to IMHO this warning doesn't really apply to this specific case. I'd love to hear from anyone who could help me figuring out how to fix this 🙂 |
Failed checksIssues marked with an ❌ are failing checks. Commit e7f631d
For more details, see the full job log. Something broken? Consider providing feedback. |
|
I can confirm it seems to be fixed on 25.12.4 |
Pull request details
Description
Fix "Name" column not showing in configurations table. Following comments at openwrt/openwrt#21746 (comment)
Fixes openwrt/openwrt#21746
Screenshot or video of changes (if applicable)
Maintainer (preferred)
@jow-
Tested on
OpenWrt version: OpenWrt 25.12.2 r32802-f505120278
LuCI version: openwrt-25.12 branch (26.086.49641~9d7c568)
Web browser(s): Firefox 149.0.2
Checklist
Signed-off-by: <my@email.address>row (viagit commit --signoff).<package name>: titlefirst line subject for packages.PKG_VERSIONin the Makefile.