Skip to content

luci-app-openvpn: add translation for OpenVPN config name option#8578

Merged
systemcrash merged 1 commit into
openwrt:openwrt-25.12from
lorthirk:fix/openvpn-name-column
May 14, 2026
Merged

luci-app-openvpn: add translation for OpenVPN config name option#8578
systemcrash merged 1 commit into
openwrt:openwrt-25.12from
lorthirk:fix/openvpn-name-column

Conversation

@lorthirk
Copy link
Copy Markdown
Contributor

@lorthirk lorthirk commented Apr 22, 2026

Pull request details

Description

Fix "Name" column not showing in configurations table. Following comments at openwrt/openwrt#21746 (comment)

Fixes openwrt/openwrt#21746

Screenshot or video of changes (if applicable)

image

Maintainer (preferred)

@jow-


Tested on

OpenWrt version: OpenWrt 25.12.2 r32802-f505120278
LuCI version: openwrt-25.12 branch (26.086.49641~9d7c568)
Web browser(s): Firefox 149.0.2


Checklist

  • This PR is not from my main or master branch 💩, but a separate branch. ✅
  • Each commit has a valid ✒️ Signed-off-by: <my@email.address> row (via git commit --signoff).
  • Each commit and PR title has a valid 📝 <package name>: title first line subject for packages.
  • Incremented 🆙 any PKG_VERSION in the Makefile.
  • (Optional) Includes what Issue it closes (e.g. openwrt/luci#issue-number).
  • (Optional) Includes what it depends on (e.g. openwrt/packages#pr-number in sister repo).

@lorthirk lorthirk force-pushed the fix/openvpn-name-column branch 4 times, most recently from 4df2843 to c2a0ce7 Compare April 22, 2026 18:42
@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

@lorthirk lorthirk force-pushed the fix/openvpn-name-column branch from c2a0ce7 to 29fffd9 Compare April 22, 2026 18:51
@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

@lorthirk lorthirk force-pushed the fix/openvpn-name-column branch 2 times, most recently from 60d5da8 to a7f9859 Compare April 22, 2026 18:57
@lorthirk lorthirk changed the title luci-app-openvpn: Add translation for OpenVPN config name option luci-app-openvpn: add translation for OpenVPN config name option Apr 22, 2026
@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

@hagaygo
Copy link
Copy Markdown

hagaygo commented May 13, 2026

Hi @lorthirk

Any chance you can fix the failed checks so it might get merged ?

Thanks in advance.

@lorthirk
Copy link
Copy Markdown
Contributor Author

Hey @hagaygo

I can sure fix the first two warnings, but I'm not really sure what do I have to do for the third one. The original file does not exist in master (nor the whole luci-app-openvpn directory), so I'm not really sure how to handle this. Any hint appreciated!

fix: name column not showing in configurations table.
following comments at
openwrt/openwrt#21746 (comment)

Fixes openwrt/openwrt#21746

Signed-off-by: Claudio Mezzasalma <claudio.mezzasalma@gmail.com>
@lorthirk lorthirk force-pushed the fix/openvpn-name-column branch from a7f9859 to e7f631d Compare May 13, 2026 06:43
@hagaygo
Copy link
Copy Markdown

hagaygo commented May 13, 2026

I am not sure myself.

I assume it means

https://git-scm.com/docs/git-cherry-pick

@lorthirk
Copy link
Copy Markdown
Contributor Author

I know what a cherry-pick is, but in order for me to cherry-pick the commit I should merge my changes to master first. The problem is that these files do not exist at all, so I cannot do that.

IMHO this warning doesn't really apply to this specific case. I'd love to hear from anyone who could help me figuring out how to fix this 🙂

@github-actions
Copy link
Copy Markdown

Warning

Some formality checks failed.

Consider (re)reading submissions guidelines.

Failed checks

Issues marked with an ❌ are failing checks.

Commit e7f631d

  • 🔶 Commit to stable branch should be marked as cherry-picked
    Actual: a stable branch (openwrt-25.12)

For more details, see the full job log.

Something broken? Consider providing feedback.

@systemcrash systemcrash merged commit 0b90dc6 into openwrt:openwrt-25.12 May 14, 2026
3 checks passed
@hagaygo
Copy link
Copy Markdown

hagaygo commented May 18, 2026

I can confirm it seems to be fixed on 25.12.4

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants