Skip to content

admin/rsyslog: add missing libyaml dependency#29472

Open
commodo wants to merge 1 commit into
openwrt:masterfrom
commodo:fix-rsyslog-yaml-dep
Open

admin/rsyslog: add missing libyaml dependency#29472
commodo wants to merge 1 commit into
openwrt:masterfrom
commodo:fix-rsyslog-yaml-dep

Conversation

@commodo
Copy link
Copy Markdown
Contributor

@commodo commodo commented May 16, 2026

📦 Package Details

Maintainer: me

Description:

The rsyslog build requires libyaml-0.so.2 at runtime, but the
package Makefile was missing this dependency in the DEPENDS list.
This caused the build to fail with:

  Package rsyslog is missing dependencies for the following libraries:
  libyaml-0.so.2

Add +libyaml to DEPENDS alongside the existing dependency on libfastjson.
The libyaml C library (0.2.5) is already available in the packages feed.

Signed-off-by: Alexandru Ardelean <alex@shruggie.ro>

🧪 Run Testing Details

  • OpenWrt Version:
  • OpenWrt Target/Subtarget:
  • OpenWrt Device:

✅ Formalities

  • I have reviewed the CONTRIBUTING.md file for detailed contributing guidelines.

@hnyman
Copy link
Copy Markdown
Contributor

hnyman commented May 16, 2026

is the library really needed, or could that feature be disabled (instead of declaring dependency)?

If it offers a minor feature, e.g. avoids a simpler built-in function, it might be more wise to disable in configure and avoid pulling in the yaml library.

@commodo
Copy link
Copy Markdown
Contributor Author

commodo commented May 18, 2026

is the library really needed, or could that feature be disabled (instead of declaring dependency)?

If it offers a minor feature, e.g. avoids a simpler built-in function, it might be more wise to disable in configure and avoid pulling in the yaml library.

apparently it can be disabled, but with a patch from master;

@commodo commodo force-pushed the fix-rsyslog-yaml-dep branch from b0ed56f to 22f22bb Compare May 18, 2026 13:32
The upstream rsyslog build links against libyaml-0.so.2 whenever
pkg-config detects yaml-0.1, which made libyaml a hard dependency
of the rsyslog binary without any way to opt out from OpenWrt
config. libyaml is only used for YAML (.yaml/.yml) configuration
files and for loading rate-limiting policies from external files;
RainerScript (.conf) installs do not need it.

Introduce a new RSYSLOG_libyaml Config.in switch, default off, and
gate the +libyaml DEPENDS entry on it. Pass --enable-libyaml or
--disable-libyaml to configure based on the switch.

The upstream configure script in 8.2604.0 does not understand a
--disable-libyaml flag (libyaml was unconditionally autodetected).
Backport upstream commit c5c244861 ("configure: make libyaml
default-on explicit") as 001-configure-make-libyaml-default-on-
explicit.patch, which adds the AC_ARG_ENABLE(libyaml) block. The
patch dissolves cleanly once the package is bumped to 8.2606.0+.
PKG_FIXUP:=autoreconf is added so the configure.ac change flows
into the generated configure script during the SDK build.

Signed-off-by: Alexandru Ardelean <alex@shruggie.ro>
@commodo commodo force-pushed the fix-rsyslog-yaml-dep branch from 22f22bb to 400ffcf Compare May 19, 2026 05:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants