qemu-ga: skip starting on bare-metal device#29483
Open
AndyChiang888 wants to merge 1 commit into
Open
Conversation
The same firmware image may be deployed on either bare metal device or virtualized platforms (e.g., Proxmox VE). On bare metal device, `qemu-ga` may still be started even though no virtio-serial channel is available, resulting in repeated attempts to access /dev/virtio-ports/org.qemu.guest_agent.0. This causes continuous service respawning by procd and unnecessary log spam. This commit adds a pre-check for /dev/virtio-ports to avoid starting `qemu-ga` when virtio-serial support is not present. Signed-off-by: Andy Chiang <AndyChiang_git@outlook.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The same firmware image may be deployed on either bare metal device or virtualized platforms (e.g., Proxmox VE).
On bare metal device,
qemu-gamay still be started even though no virtio-serial channel is available, resulting in repeated attempts to access /dev/virtio-ports/org.qemu.guest_agent.0.This causes continuous service respawning by procd and unnecessary log spam.
This commit adds a pre-check for /dev/virtio-ports to avoid starting
qemu-gawhen virtio-serial support is not present.related logs:
📦 Package Details
Maintainer: @
(You can find this by checking the history of the package
Makefile.)Description:
🧪 Run Testing Details
✅ Formalities
If your PR contains a patch:
git am(e.g., subject line, commit description, etc.)
We must try to upstream patches to reduce maintenance burden.