ola: fix host compilation in buildbot#29485
Open
GeorgeSapkin wants to merge 1 commit into
Open
Conversation
GeorgeSapkin
force-pushed
the
ola-fix-host-includes
branch
from
e640a3c to
e14b662
Compare
Add explicit host includes to fix uuid.h lookup in buildbot. Fixes: 5e4f937 ("ola: use protobuf-compat instead of protobuf") Signed-off-by: George Sapkin <george@sapk.in>
GeorgeSapkin
force-pushed
the
ola-fix-host-includes
branch
from
e14b662 to
e4454f4
Compare
GeorgeSapkin
changed the title
Contributor
|
Similar approach but more compact: #29473 Apparently the |
bk138
reviewed
May 19, 2026
| CXXFLAGS="-I$(STAGING_DIR_HOSTPKG)/usr/protobuf-compat/include $(HOST_CXXFLAGS)" \ | ||
| LDFLAGS="-L$(STAGING_DIR_HOSTPKG)/usr/protobuf-compat/lib $(HOST_LDFLAGS)" | ||
| PKG_CONFIG_PATH="$(STAGING_DIR_HOSTPKG)/usr/protobuf-compat/lib/pkgconfig:$(STAGING_DIR_HOST)/lib/pkgconfig:$(PKG_CONFIG_PATH)" \ | ||
| CPPFLAGS="-I$(STAGING_DIR_HOSTPKG)/usr/protobuf-compat/include -I$(STAGING_DIR_HOST)/include $(HOST_CPPFLAGS)" \ |
Contributor
There was a problem hiding this comment.
Looks good! I wonder if we can get rid of the special $(STAGING_DIR_HOSTPKG)/usr/protobuf-compat/include and just use $(STAGING_DIR_HOST)/include ?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📦 Package Details
Maintainer: @bk138
Description:
Add explicit host includes to fix uuid.h lookup in buildbot.
Fixes: 5e4f937 ("ola: use protobuf-compat instead of protobuf")
🧪 Run Testing Details
Compile-tested only.
✅ Formalities