fish: fix postrm script interpreter#29774
Open
dhrm1k wants to merge 1 commit into
Open
Conversation
BKPepe
reviewed
Jun 21, 2026
b6e67fa to
3706fe0
Compare
Contributor
Author
|
CI is failing. My previous PRs did not hit this, Did it change recently? |
Add the missing shell interpreter line to the postrm script. This lets apk run the generated post-deinstall hook when fish is removed. Bump PKG_RELEASE for the package script change. Fixes: openwrt#29348 Signed-off-by: Dharmik Parmar <dharmikparmar2004@yahoo.com>
3706fe0 to
1246187
Compare
Contributor
Author
|
I noticed this same apk-side failure in another package too ( It looks like the common pattern is that apk executes the generated maintainer Will it be helpful if I look into a few more of these, or will it be considered |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add the missing shell interpreter line to the fish
postrmscript so apk canrun the generated post-deinstall hook when fish is removed.
Without the shebang, apk:
Fixes: #29348
📦 Package Details
Maintainer: Curtis Jiang @jqqqqqqqqqq
Description:
Fix the fish package removal hook by adding the missing
#!/bin/shline tothe generated
postrmscript.🧪 Run Testing Details
Tested with:
Before this change,
apk del fishreportedexecve: Exec format errorwhilerunning the fish post-deinstall hook.
✅ Formalities
If your PR contains a patch: