Skip to content

Refactor the API for diagnostic requests to be more obvious #180

@peplin

Description

@peplin

If you pass a DiagnosticRequest to VehicleManager.send(...), it will wrap that in a CommandMessage and set the action field to ADD. If you want to cancel a diagnostic request, you have to build your own Command and set the action to CANCEL.

That seems OK, but then the API gets confused - if you pass a Command with a DiagnosticRequest inside to VehicleManager.request(...), it won't set up the correct listener. It'll be looking for a command response instead of a diagnostic response.

Metadata

Metadata

Assignees

No one assigned

    Labels

    future workIssues that are not high on the priority list.ready

    Type

    No type
    No fields configured for issues without a type.

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions