Fix Gather/Scatter sharding rule for dimensions not in start_index_map.#1085
Open
copybara-service[bot] wants to merge 1 commit into
Open
Fix Gather/Scatter sharding rule for dimensions not in start_index_map.#1085copybara-service[bot] wants to merge 1 commit into
copybara-service[bot] wants to merge 1 commit into
Conversation
For the gather operand, its dimension can be 1. batching dimension 2. pointed out by the `start_index_map`. It can be a 2.1 pass-through dimension (dimension size is the same as slice size) 2.2 reduction dimension (dimension size and slice size are different and slice size is 1) 2.3 need-replication dimension (dimension size and slice size are different and slice size is not 1) 3. other dimensions. The factor type is 3.1 pass-through dimension (dimension size is the same as slice size) 3.2 need-replication dimension (dimension size and slice size are different) We may want to update 3.2 as reduction dimension in the future. PiperOrigin-RevId: 889374677
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix Gather/Scatter sharding rule for dimensions not in start_index_map.
For the gather operand, its dimension can be
start_index_map. It can be a2.1 pass-through dimension (dimension size is the same as slice size)
2.2 reduction dimension (dimension size and slice size are different and slice size is 1)
2.3 need-replication dimension (dimension size and slice size are different and slice size is not 1)
3.1 pass-through dimension (dimension size is the same as slice size)
3.2 need-replication dimension (dimension size and slice size are different)
We may want to update 3.2 as reduction dimension in the future.