[mpmd] Extract WrapBlockArgReturnsPass from UniquifyFunctionInputsOutputsPass.#1302
Open
copybara-service[bot] wants to merge 1 commit into
Open
[mpmd] Extract WrapBlockArgReturnsPass from UniquifyFunctionInputsOutputsPass.#1302copybara-service[bot] wants to merge 1 commit into
copybara-service[bot] wants to merge 1 commit into
Conversation
…putsPass. Separates the two orthogonal concerns in UniquifyFunctionInputsOutputsPass: - Block-arg wrapping: ensuring block arguments returned directly by MPMD functions pass through a fragment (for sharding constraint attachment). - Return uniquification: creating unique SSA values for duplicated returns. Introduces WrapBlockArgReturnsPass (mpmd-wrap-block-arg-returns) which handles the first concern. The existing pass's fragment mode is simplified to only handle duplicated returns (size > 1 filter). The export pipeline now runs wrap before uniquify. The transfer mode used by the sharding propagation pipeline is completely unaffected. PiperOrigin-RevId: 910564666
copybara-service
Bot
force-pushed
the
test_910564666
branch
from
33c1a5e to
d34a6cb
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
[mpmd] Extract WrapBlockArgReturnsPass from UniquifyFunctionInputsOutputsPass.
Separates the two orthogonal concerns in UniquifyFunctionInputsOutputsPass:
functions pass through a fragment (for sharding constraint attachment).
Introduces WrapBlockArgReturnsPass (mpmd-wrap-block-arg-returns) which handles
the first concern. The existing pass's fragment mode is simplified to only
handle duplicated returns (size > 1 filter).
The export pipeline now runs wrap before uniquify. The transfer mode used by
the sharding propagation pipeline is completely unaffected.