Overwriting redirects with an item is no longer allowed - #1072
Merged
kelson42 merged 7 commits intoApr 18, 2026
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1072 +/- ##
==========================================
+ Coverage 56.42% 56.48% +0.06%
==========================================
Files 101 101
Lines 5069 5065 -4
Branches 2211 2208 -3
==========================================
+ Hits 2860 2861 +1
+ Misses 741 737 -4
+ Partials 1468 1467 -1 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Contributor
|
@veloman-yunkan How does the libzim behaves if we try to overwrite an item? I thought we should get rid of ASSERT!? #723 |
Collaborator
Author
A
How does it apply to this PR? |
kelson42
deleted the
overwriting_redirects_with_an_item_no_longer_possible
branch
April 18, 2026 17:37
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1071
The PR mostly consists of new unit-tests demonstrating how attempts to overwrite existing entries work. Various combinations of the types of the existing entry and the entry being added are tested. The last commit eliminates the deliberate possibility of overwriting a redirection entry with an item entry, updating the unit tests correspondingly.