feat: working settings + skip domains

Author: nikitalokhmachev-ai

src/ext/bg.ts

@@ -9,6 +9,7 @@ import {
   setLocalOption,
   getSharedArchives,
 } from "../localstorage";
+import { isValidUrl } from "../utils";
 // ===========================================================================
 self.recorders = {};
 self.newRecId = null;
@@ -22,6 +23,7 @@ let newRecCollId = null;
 let defaultCollId = null;
 let autorun = false;
 let isRecordingEnabled = false;
+let skipDomains = [] as string[];
 
 const openWinMap = new Map();
 
@@ -32,6 +34,12 @@ const disabledCSPTabs = new Set();
 // @ts-expect-error - TS7034 - Variable 'sidepanelPort' implicitly has type 'any' in some locations where its type cannot be determined.
 let sidepanelPort = null;
 
+(async function loadSkipDomains() {
+  // @ts-expect-error
+  skipDomains = (await getLocalOption("skipDomains")) || [];
+  console.log("bg.skipDomains:", skipDomains);
+})();
+
 // ===========================================================================
 
 function main() {
@@ -136,7 +144,7 @@ function sidepanelHandler(port) {
           //@ts-expect-error tabs has any type
           async (tabs) => {
             for (const tab of tabs) {
-              if (!isValidUrl(tab.url)) continue;
+              if (!isValidUrl(tab.url, skipDomains)) continue;
 
               await startRecorder(
                 tab.id,
@@ -217,6 +225,13 @@ chrome.runtime.onMessage.addListener(
   (message /*sender, sendResponse*/) => {
     console.log("onMessage", message);
     switch (message.msg) {
+      case "optionsChanged":
+        for (const rec of Object.values(self.recorders)) {
+          rec.initOpts();
+          rec.doUpdateStatus();
+        }
+        break;
+
       case "startNew":
         (async () => {
           newRecUrl = message.url;
@@ -256,7 +271,7 @@ chrome.tabs.onActivated.addListener(async ({ tabId }) => {
     chrome.tabs.get(tabId, resolve),
   );
 
-  if (!isValidUrl(tab.url)) return;
+  if (!isValidUrl(tab.url, skipDomains)) return;
   if (!self.recorders[tabId]) {
     await startRecorder(
       tabId,
@@ -296,7 +311,7 @@ chrome.tabs.onCreated.addListener((tab) => {
     newRecCollId = null;
   } else if (
     tab.openerTabId &&
-    (!tab.pendingUrl || isValidUrl(tab.pendingUrl)) &&
+    (!tab.pendingUrl || isValidUrl(tab.pendingUrl, skipDomains)) &&
     // @ts-expect-error - TS2339 - Property 'running' does not exist on type 'BrowserRecorder'.
     self.recorders[tab.openerTabId]?.running
   ) {
@@ -311,7 +326,7 @@ chrome.tabs.onCreated.addListener((tab) => {
   }
 
   if (start) {
-    if (openUrl && !isValidUrl(openUrl)) {
+    if (openUrl && !isValidUrl(openUrl, skipDomains)) {
       return;
     }
     startRecorder(
@@ -339,7 +354,7 @@ chrome.tabs.onUpdated.addListener((tabId, changeInfo) => {
 
     // @ts-expect-error - TS2339 - Property 'waitForTabUpdate' does not exist on type 'BrowserRecorder'.
     if (recorder.waitForTabUpdate) {
-      if (isValidUrl(changeInfo.url)) {
+      if (isValidUrl(changeInfo.url, skipDomains)) {
         recorder.attach();
       } else {
         // @ts-expect-error - TS2339 - Property 'waitForTabUpdate' does not exist on type 'BrowserRecorder'.
@@ -351,7 +366,7 @@ chrome.tabs.onUpdated.addListener((tabId, changeInfo) => {
   } else if (changeInfo.url) {
     if (
       isRecordingEnabled &&
-      isValidUrl(changeInfo.url) &&
+      isValidUrl(changeInfo.url, skipDomains) &&
       !self.recorders[tabId]
     ) {
       // @ts-expect-error - TS2554 - Expected 2 arguments, but got 3.
@@ -361,7 +376,7 @@ chrome.tabs.onUpdated.addListener((tabId, changeInfo) => {
     if (openWinMap.has(changeInfo.url)) {
       const collId = openWinMap.get(changeInfo.url);
       openWinMap.delete(changeInfo.url);
-      if (!tabId || !isValidUrl(changeInfo.url)) return;
+      if (!tabId || !isValidUrl(changeInfo.url, skipDomains)) return;
 
       // @ts-expect-error - TS2554 - Expected 2 arguments, but got 3.
       startRecorder(tabId, { collId, autorun }, changeInfo.url);
@@ -386,7 +401,7 @@ chrome.contextMenus.onClicked.addListener((info, tab) => {
 
     case "toggle-rec":
       if (!isRecording(tab.id)) {
-        if (isValidUrl(tab.url)) {
+        if (isValidUrl(tab.url, skipDomains)) {
           // @ts-expect-error - TS2554 - Expected 2 arguments, but got 1.
           startRecorder(tab.id);
         }
@@ -457,17 +472,6 @@ function isRecording(tabId) {
   return self.recorders[tabId]?.running;
 }
 
-// ===========================================================================
-// @ts-expect-error - TS7006 - Parameter 'url' implicitly has an 'any' type.
-function isValidUrl(url) {
-  return (
-    url &&
-    (url === "about:blank" ||
-      url.startsWith("https:") ||
-      url.startsWith("http:"))
-  );
-}
-
 // ===========================================================================
 // @ts-expect-error - TS7006 - Parameter 'tabId' implicitly has an 'any' type.
 async function disableCSPForTab(tabId) {

src/recorder.ts

@@ -1,5 +1,5 @@
 import { RequestResponseInfo } from "./requestresponseinfo";
-
+import { isValidUrl, isUrlInSkipList } from "./utils";
 import {
   getCustomRewriter,
   rewriteDASH,
@@ -60,6 +60,7 @@ class Recorder {
   archiveFlash = false;
   archiveScreenshots = false;
   archivePDF = false;
+  skipDomains: string[] = [];
 
   _fetchQueue: FetchEntry[] = [];
 
@@ -163,6 +164,9 @@ class Recorder {
     this.archiveScreenshots =
       (await getLocalOption("archiveScreenshots")) === "1";
     this.archivePDF = (await getLocalOption("archivePDF")) === "1";
+    // @ts-expect-error
+    this.skipDomains = (await getLocalOption("skipDomains")) || [];
+    console.log("recorder.skipDomains", this.skipDomains);
   }
 
   // @ts-expect-error - TS7006 - Parameter 'autorun' implicitly has an 'any' type.
@@ -1111,6 +1115,9 @@ class Recorder {
 
   // @ts-expect-error - TS7006 - Parameter 'currPage' implicitly has an 'any' type. | TS7006 - Parameter 'domSnapshot' implicitly has an 'any' type. | TS7006 - Parameter 'finished' implicitly has an 'any' type.
   commitPage(currPage, domSnapshot, finished) {
+    if (isUrlInSkipList(currPage?.url, this.skipDomains)) {
+      return;
+    }
     if (!currPage?.url || !currPage.ts || currPage.url === "about:blank") {
       return;
     }
@@ -1135,6 +1142,10 @@ class Recorder {
 
   // @ts-expect-error - TS7006 - Parameter 'data' implicitly has an 'any' type. | TS7006 - Parameter 'pageInfo' implicitly has an 'any' type.
   async commitResource(data, pageInfo) {
+    if (isUrlInSkipList(data.url, this.skipDomains)) {
+      return;
+    }
+
     const payloadSize = data.payload.length;
     // @ts-expect-error - TS2339 - Property 'pageInfo' does not exist on type 'Recorder'.
     pageInfo = pageInfo || this.pageInfo;
@@ -1552,11 +1563,6 @@ class Recorder {
     return !status || status === 204 || (status >= 300 && status < 400);
   }
 
-  // @ts-expect-error - TS7006 - Parameter 'url' implicitly has an 'any' type.
-  isValidUrl(url) {
-    return url && (url.startsWith("https:") || url.startsWith("http:"));
-  }
-
   // @ts-expect-error - TS7006 - Parameter 'params' implicitly has an 'any' type. | TS7006 - Parameter 'sessions' implicitly has an 'any' type.
   async handleLoadingFinished(params, sessions) {
     const reqresp = this.removeReqResp(params.requestId);
@@ -1566,7 +1572,7 @@ class Recorder {
       return;
     }
 
-    if (!this.isValidUrl(reqresp.url)) {
+    if (!isValidUrl(reqresp.url, this.skipDomains)) {
       return;
     }
 
@@ -1830,7 +1836,7 @@ class Recorder {
 
   // @ts-expect-error - TS7006 - Parameter 'request' implicitly has an 'any' type. | TS7006 - Parameter 'sessions' implicitly has an 'any' type.
   doAsyncFetch(request: FetchEntry, sessions) {
-    if (!request || !this.isValidUrl(request.url)) {
+    if (!request || !isValidUrl(request.url, this.skipDomains)) {
       return;
     }