wip

Signed-off-by: Attila Mészáros <a_meszaros@apple.com>

# Conflicts:
#	operator-framework-core/src/main/java/io/javaoperatorsdk/operator/processing/event/source/informer/pool/DefaultInformerPool.java

Author: csviri

operator-framework-core/src/main/java/io/javaoperatorsdk/operator/api/config/AbstractConfigurationService.java

@@ -200,7 +200,8 @@ public synchronized InformerPool informerPool() {
     // can therefore share the underlying informers; synchronized so concurrent first-access from
     // multiple controllers cannot create (and share out) more than one pool instance
     if (informerPool == null) {
-      informerPool = new DefaultInformerPool(this);
+      informerPool = new DefaultInformerPool();
+      informerPool.setConfigurationService(this);
     }
     return informerPool;
   }

operator-framework-core/src/main/java/io/javaoperatorsdk/operator/processing/event/source/informer/pool/DefaultInformerPool.java

@@ -26,7 +26,6 @@
 import io.fabric8.kubernetes.api.model.HasMetadata;
 import io.fabric8.kubernetes.client.KubernetesClient;
 import io.fabric8.kubernetes.client.informers.SharedIndexInformer;
-import io.javaoperatorsdk.operator.api.config.ConfigurationService;
 
 public class DefaultInformerPool extends AbstractInformerPool {
 
@@ -35,11 +34,6 @@ public class DefaultInformerPool extends AbstractInformerPool {
   private final Map<InformerClassifier<?>, SharedIndexInformer<?>> informers = new HashMap<>();
   private final Map<InformerClassifier<?>, AtomicInteger> counters = new HashMap<>();
 
-  public DefaultInformerPool(ConfigurationService service) {
-    setConfigurationService(service);
-  }
-
-  @Override
   @SuppressWarnings("unchecked")
   @Override
   public <R extends HasMetadata> SharedIndexInformer<R> getInformer(

operator-framework-core/src/main/java/io/javaoperatorsdk/operator/processing/event/source/informer/pool/InformerPool.java

@@ -54,5 +54,6 @@ <R extends HasMetadata> Optional<SharedIndexInformer<R>> releaseInformer(
    */
   long numberOfInformersForResource(Class<? extends HasMetadata> resourceClass);
 
+  /** Injecting the configuration service, so users have a cleaner API creating the pool. */
   void setConfigurationService(ConfigurationService configurationService);
 }

operator-framework-core/src/test/java/io/javaoperatorsdk/operator/processing/event/source/informer/pool/DefaultInformerPoolTest.java

@@ -15,6 +15,7 @@
  */
 package io.javaoperatorsdk.operator.processing.event.source.informer.pool;
 
+import org.junit.jupiter.api.BeforeEach;
 import org.junit.jupiter.api.Test;
 
 import io.fabric8.kubernetes.client.KubernetesClient;
@@ -38,7 +39,12 @@ class DefaultInformerPoolTest {
   private static final String ES_NAME = "event-source";
 
   private final KubernetesClient client = MockKubernetesClient.client(TestCustomResource.class);
-  private final DefaultInformerPool pool = new DefaultInformerPool(new BaseConfigurationService());
+  private final DefaultInformerPool pool = new DefaultInformerPool();
+
+  @BeforeEach
+  void setup() {
+    pool.setConfigurationService(new BaseConfigurationService());
+  }
 
   @Test
   void sharesSingleInformerForTheSameClassifier() {