test case for reported issue

Signed-off-by: Attila Mészáros <a_meszaros@apple.com>

Author: csviri

operator-framework/src/test/java/io/javaoperatorsdk/operator/workflow/preconditionandactivation/ConfigMapDependentResource.java

@@ -0,0 +1,38 @@
+/*
+ * Copyright Java Operator SDK Authors
+ *
+ * Licensed under the Apache License, Version 2.0 (the "License");
+ * you may not use this file except in compliance with the License.
+ * You may obtain a copy of the License at
+ *
+ *         http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package io.javaoperatorsdk.operator.workflow.preconditionandactivation;
+
+import io.fabric8.kubernetes.api.model.ConfigMap;
+import io.fabric8.kubernetes.api.model.ObjectMetaBuilder;
+import io.javaoperatorsdk.operator.api.reconciler.Context;
+import io.javaoperatorsdk.operator.processing.dependent.kubernetes.CRUDKubernetesDependentResource;
+
+public class ConfigMapDependentResource
+    extends CRUDKubernetesDependentResource<ConfigMap, PreconditionAndActivationCustomResource> {
+
+  @Override
+  protected ConfigMap desired(
+      PreconditionAndActivationCustomResource primary,
+      Context<PreconditionAndActivationCustomResource> context) {
+    ConfigMap configMap = new ConfigMap();
+    configMap.setMetadata(
+        new ObjectMetaBuilder()
+            .withName(primary.getMetadata().getName())
+            .withNamespace(primary.getMetadata().getNamespace())
+            .build());
+    return configMap;
+  }
+}

operator-framework/src/test/java/io/javaoperatorsdk/operator/workflow/preconditionandactivation/FalseActivationCondition.java

@@ -0,0 +1,32 @@
+/*
+ * Copyright Java Operator SDK Authors
+ *
+ * Licensed under the Apache License, Version 2.0 (the "License");
+ * you may not use this file except in compliance with the License.
+ * You may obtain a copy of the License at
+ *
+ *         http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package io.javaoperatorsdk.operator.workflow.preconditionandactivation;
+
+import io.fabric8.kubernetes.api.model.Secret;
+import io.javaoperatorsdk.operator.api.reconciler.Context;
+import io.javaoperatorsdk.operator.api.reconciler.dependent.DependentResource;
+import io.javaoperatorsdk.operator.processing.dependent.workflow.Condition;
+
+public class FalseActivationCondition
+    implements Condition<Secret, PreconditionAndActivationCustomResource> {
+  @Override
+  public boolean isMet(
+      DependentResource<Secret, PreconditionAndActivationCustomResource> dependentResource,
+      PreconditionAndActivationCustomResource primary,
+      Context<PreconditionAndActivationCustomResource> context) {
+    return false;
+  }
+}

operator-framework/src/test/java/io/javaoperatorsdk/operator/workflow/preconditionandactivation/FalseReconcilePrecondition.java

@@ -0,0 +1,32 @@
+/*
+ * Copyright Java Operator SDK Authors
+ *
+ * Licensed under the Apache License, Version 2.0 (the "License");
+ * you may not use this file except in compliance with the License.
+ * You may obtain a copy of the License at
+ *
+ *         http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package io.javaoperatorsdk.operator.workflow.preconditionandactivation;
+
+import io.fabric8.kubernetes.api.model.ConfigMap;
+import io.javaoperatorsdk.operator.api.reconciler.Context;
+import io.javaoperatorsdk.operator.api.reconciler.dependent.DependentResource;
+import io.javaoperatorsdk.operator.processing.dependent.workflow.Condition;
+
+public class FalseReconcilePrecondition
+    implements Condition<ConfigMap, PreconditionAndActivationCustomResource> {
+  @Override
+  public boolean isMet(
+      DependentResource<ConfigMap, PreconditionAndActivationCustomResource> dependentResource,
+      PreconditionAndActivationCustomResource primary,
+      Context<PreconditionAndActivationCustomResource> context) {
+    return false;
+  }
+}

operator-framework/src/test/java/io/javaoperatorsdk/operator/workflow/preconditionandactivation/PreconditionAndActivationCustomResource.java

@@ -0,0 +1,28 @@
+/*
+ * Copyright Java Operator SDK Authors
+ *
+ * Licensed under the Apache License, Version 2.0 (the "License");
+ * you may not use this file except in compliance with the License.
+ * You may obtain a copy of the License at
+ *
+ *         http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package io.javaoperatorsdk.operator.workflow.preconditionandactivation;
+
+import io.fabric8.kubernetes.api.model.Namespaced;
+import io.fabric8.kubernetes.client.CustomResource;
+import io.fabric8.kubernetes.model.annotation.Group;
+import io.fabric8.kubernetes.model.annotation.ShortNames;
+import io.fabric8.kubernetes.model.annotation.Version;
+
+@Group("sample.javaoperatorsdk")
+@Version("v1")
+@ShortNames("paa")
+public class PreconditionAndActivationCustomResource extends CustomResource<Void, Void>
+    implements Namespaced {}

operator-framework/src/test/java/io/javaoperatorsdk/operator/workflow/preconditionandactivation/PreconditionAndActivationIT.java

@@ -0,0 +1,65 @@
+/*
+ * Copyright Java Operator SDK Authors
+ *
+ * Licensed under the Apache License, Version 2.0 (the "License");
+ * you may not use this file except in compliance with the License.
+ * You may obtain a copy of the License at
+ *
+ *         http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package io.javaoperatorsdk.operator.workflow.preconditionandactivation;
+
+import org.junit.jupiter.api.Test;
+import org.junit.jupiter.api.extension.RegisterExtension;
+
+import io.fabric8.kubernetes.api.model.ConfigMap;
+import io.fabric8.kubernetes.api.model.ObjectMetaBuilder;
+import io.fabric8.kubernetes.api.model.Secret;
+import io.javaoperatorsdk.operator.junit.LocallyRunOperatorExtension;
+
+import static org.assertj.core.api.Assertions.assertThat;
+import static org.awaitility.Awaitility.await;
+
+class PreconditionAndActivationIT {
+
+  public static final String TEST_RESOURCE_NAME = "test1";
+
+  @RegisterExtension
+  LocallyRunOperatorExtension extension =
+      LocallyRunOperatorExtension.builder()
+          .withReconciler(PreconditionAndActivationReconciler.class)
+          .build();
+
+  @Test
+  void handlesFalsePreconditionWithNonActive() {
+    extension.create(testResource());
+
+    await()
+        .untilAsserted(
+            () -> {
+              assertThat(
+                      extension
+                          .getReconcilerOfType(PreconditionAndActivationReconciler.class)
+                          .getNumberOfReconciliationExecution())
+                  .isPositive();
+            });
+
+    // Neither resource should be created
+    var cm = extension.get(ConfigMap.class, TEST_RESOURCE_NAME);
+    assertThat(cm).isNull();
+    var secret = extension.get(Secret.class, TEST_RESOURCE_NAME);
+    assertThat(secret).isNull();
+  }
+
+  private PreconditionAndActivationCustomResource testResource() {
+    var res = new PreconditionAndActivationCustomResource();
+    res.setMetadata(new ObjectMetaBuilder().withName(TEST_RESOURCE_NAME).build());
+    return res;
+  }
+}

operator-framework/src/test/java/io/javaoperatorsdk/operator/workflow/preconditionandactivation/PreconditionAndActivationReconciler.java

@@ -0,0 +1,67 @@
+/*
+ * Copyright Java Operator SDK Authors
+ *
+ * Licensed under the Apache License, Version 2.0 (the "License");
+ * you may not use this file except in compliance with the License.
+ * You may obtain a copy of the License at
+ *
+ *         http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package io.javaoperatorsdk.operator.workflow.preconditionandactivation;
+
+import java.util.concurrent.atomic.AtomicInteger;
+
+import io.javaoperatorsdk.operator.api.reconciler.Context;
+import io.javaoperatorsdk.operator.api.reconciler.ControllerConfiguration;
+import io.javaoperatorsdk.operator.api.reconciler.Reconciler;
+import io.javaoperatorsdk.operator.api.reconciler.UpdateControl;
+import io.javaoperatorsdk.operator.api.reconciler.Workflow;
+import io.javaoperatorsdk.operator.api.reconciler.dependent.Dependent;
+
+@Workflow(
+    dependents = {
+      @Dependent(
+          name = "configmap",
+          type = ConfigMapDependentResource.class,
+          reconcilePrecondition = FalseReconcilePrecondition.class),
+      @Dependent(
+          type = SecretDependentResource.class,
+          activationCondition = FalseActivationCondition.class,
+          dependsOn = "configmap")
+    })
+@ControllerConfiguration
+public class PreconditionAndActivationReconciler
+    implements Reconciler<PreconditionAndActivationCustomResource> {
+
+  private final AtomicInteger numberOfReconciliationExecution = new AtomicInteger(0);
+
+  @Override
+  public UpdateControl<PreconditionAndActivationCustomResource> reconcile(
+      PreconditionAndActivationCustomResource resource,
+      Context<PreconditionAndActivationCustomResource> context) {
+
+    var workflowResult =
+        context
+            .managedWorkflowAndDependentResourceContext()
+            .getWorkflowReconcileResult()
+            .orElseThrow();
+    var erroredDependents = workflowResult.getErroredDependents();
+    if (!erroredDependents.isEmpty()) {
+      throw new RuntimeException(
+          "Unexpected workflow error", erroredDependents.values().iterator().next());
+    }
+
+    numberOfReconciliationExecution.incrementAndGet();
+    return UpdateControl.noUpdate();
+  }
+
+  public int getNumberOfReconciliationExecution() {
+    return numberOfReconciliationExecution.get();
+  }
+}

operator-framework/src/test/java/io/javaoperatorsdk/operator/workflow/preconditionandactivation/SecretDependentResource.java

@@ -0,0 +1,38 @@
+/*
+ * Copyright Java Operator SDK Authors
+ *
+ * Licensed under the Apache License, Version 2.0 (the "License");
+ * you may not use this file except in compliance with the License.
+ * You may obtain a copy of the License at
+ *
+ *         http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package io.javaoperatorsdk.operator.workflow.preconditionandactivation;
+
+import io.fabric8.kubernetes.api.model.ObjectMetaBuilder;
+import io.fabric8.kubernetes.api.model.Secret;
+import io.javaoperatorsdk.operator.api.reconciler.Context;
+import io.javaoperatorsdk.operator.processing.dependent.kubernetes.CRUDKubernetesDependentResource;
+
+public class SecretDependentResource
+    extends CRUDKubernetesDependentResource<Secret, PreconditionAndActivationCustomResource> {
+
+  @Override
+  protected Secret desired(
+      PreconditionAndActivationCustomResource primary,
+      Context<PreconditionAndActivationCustomResource> context) {
+    Secret secret = new Secret();
+    secret.setMetadata(
+        new ObjectMetaBuilder()
+            .withName(primary.getMetadata().getName())
+            .withNamespace(primary.getMetadata().getNamespace())
+            .build());
+    return secret;
+  }
+}