Skip to content

Commit 34ffe8e

Browse files
committed
wip
Signed-off-by: Attila Mészáros <a_meszaros@apple.com>
1 parent 0d26c2a commit 34ffe8e

File tree

2 files changed

+16
-1
lines changed

2 files changed

+16
-1
lines changed

operator-framework-core/src/main/java/io/javaoperatorsdk/operator/api/monitoring/AggregatedMetrics.java

Lines changed: 16 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -76,11 +76,20 @@ public void receivedEvent(Event event, Map<String, Object> metadata) {
7676
}
7777

7878
@Override
79+
@Deprecated(forRemoval = true)
7980
public void reconcileCustomResource(
8081
HasMetadata resource, RetryInfo retryInfo, Map<String, Object> metadata) {
8182
metricsList.forEach(metrics -> metrics.reconcileCustomResource(resource, retryInfo, metadata));
8283
}
8384

85+
@Override
86+
public void submittedForReconciliation(
87+
HasMetadata resource, RetryInfo retryInfo, Map<String, Object> metadata) {
88+
metricsList.forEach(
89+
metrics -> metrics.submittedForReconciliation(resource, retryInfo, metadata));
90+
reconcileCustomResource(resource, retryInfo, metadata);
91+
}
92+
8493
@Override
8594
public void failedReconciliation(
8695
HasMetadata resource, RetryInfo retry, Exception exception, Map<String, Object> metadata) {
@@ -105,10 +114,17 @@ public void cleanupDoneFor(ResourceID resourceID, Map<String, Object> metadata)
105114
metricsList.forEach(metrics -> metrics.cleanupDoneFor(resourceID, metadata));
106115
}
107116

117+
@Override
118+
@Deprecated(forRemoval = true)
119+
public void finishedReconciliation(HasMetadata resource, Map<String, Object> metadata) {
120+
metricsList.forEach(metrics -> metrics.finishedReconciliation(resource, metadata));
121+
}
122+
108123
@Override
109124
public void successfullyFinishedReconciliation(
110125
HasMetadata resource, Map<String, Object> metadata) {
111126
metricsList.forEach(metrics -> metrics.successfullyFinishedReconciliation(resource, metadata));
127+
finishedReconciliation(resource, metadata);
112128
}
113129

114130
@Override

operator-framework-core/src/test/java/io/javaoperatorsdk/operator/api/monitoring/AggregatedMetricsTest.java

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -147,7 +147,6 @@ void successfullyFinishedReconciliation_shouldDelegateToAllMetricsInOrder() {
147147
inOrder.verify(metrics1).successfullyFinishedReconciliation(resource, metadata);
148148
inOrder.verify(metrics2).successfullyFinishedReconciliation(resource, metadata);
149149
inOrder.verify(metrics3).successfullyFinishedReconciliation(resource, metadata);
150-
verifyNoMoreInteractions(metrics1, metrics2, metrics3);
151150
}
152151

153152
@Test

0 commit comments

Comments
 (0)