Skip to content

Commit 43b9826

Browse files
committed
fixes from code review
Signed-off-by: Attila Mészáros <a_meszaros@apple.com>
1 parent 5abf316 commit 43b9826

File tree

3 files changed

+4
-4
lines changed

3 files changed

+4
-4
lines changed

operator-framework-core/src/main/java/io/javaoperatorsdk/operator/processing/event/ReconciliationDispatcher.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -315,7 +315,7 @@ private PostExecutionControl<P> handleCleanup(
315315
}
316316
}
317317
log.debug(
318-
"Skipping finalizer remove for resource. Delete control: {}, uses finalizer: {}",
318+
"Skipping finalizer remove for resource. Delete control: {}, uses finalizer: {}",
319319
deleteControl,
320320
useFinalizer);
321321
PostExecutionControl<P> postExecutionControl = PostExecutionControl.defaultDispatch();

operator-framework-core/src/main/java/io/javaoperatorsdk/operator/processing/event/source/informer/ManagedInformerEventSource.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -94,7 +94,7 @@ public void changeNamespaces(Set<String> namespaces) {
9494
@SuppressWarnings("unchecked")
9595
public R eventFilteringUpdateAndCacheResource(R resourceToUpdate, UnaryOperator<R> updateMethod) {
9696
ResourceID id = ResourceID.fromResource(resourceToUpdate);
97-
log.debug("Starting event filter and cache update");
97+
log.debug("Starting event filtering and cacheing update");
9898
R updatedResource = null;
9999
try {
100100
temporaryResourceCache.startEventFilteringModify(id);
@@ -128,7 +128,7 @@ public R eventFilteringUpdateAndCacheResource(R resourceToUpdate, UnaryOperator<
128128
updatedForLambda != null ? updatedForLambda : extendedResourcePrevVersion;
129129
if (log.isDebugEnabled()) {
130130
log.debug(
131-
"Extended previous resource version: {} resource from update present: {}"
131+
"Previous resource version: {} resource from update present: {}"
132132
+ " extendedPrevResource present: {}",
133133
prevVersionOfResource.getMetadata().getResourceVersion(),
134134
updatedForLambda != null,

operator-framework-core/src/main/java/io/javaoperatorsdk/operator/processing/event/source/informer/TemporaryResourceCache.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -130,8 +130,8 @@ private synchronized EventHandling onEvent(
130130
log.debug("Processing event for resource");
131131
}
132132
if (!unknownState) {
133-
log.debug("Setting latest resource version to: {}", latestResourceVersion);
134133
latestResourceVersion = resource.getMetadata().getResourceVersion();
134+
log.debug("Setting latest resource version to: {}", latestResourceVersion);
135135
}
136136
var cached = cache.get(resourceId);
137137
EventHandling result = EventHandling.NEW;

0 commit comments

Comments
 (0)