Avoiding condition double checking

Signed-off-by: Attila Mészáros <a_meszaros@apple.com>

Author: csviri

operator-framework-core/src/main/java/io/javaoperatorsdk/operator/processing/dependent/workflow/AbstractWorkflowExecutor.java

@@ -157,6 +157,13 @@ protected <R> boolean isConditionMet(
     return condition
         .map(
             c -> {
+              synchronized (this) {
+                Optional<DetailedCondition.Result> existingResult =
+                    createOrGetResultFor(dependentResource).getConditionResult(c.type());
+                if (existingResult.isPresent()) {
+                  return existingResult.get();
+                }
+              }
               final DetailedCondition.Result<?> r = c.detailedIsMet(dr, primary, context);
               synchronized (this) {
                 results

operator-framework-core/src/main/java/io/javaoperatorsdk/operator/processing/dependent/workflow/BaseWorkflowResult.java

@@ -172,6 +172,15 @@ public boolean hasPostDeleteConditionNotMet() {
       return deletePostconditionResult != null && !deletePostconditionResult.isSuccess();
     }
 
+    public Optional<DetailedCondition.Result> getConditionResult(Condition.Type conditionType) {
+      return switch (conditionType) {
+        case ACTIVATION -> Optional.ofNullable(activationConditionResult);
+        case DELETE -> Optional.ofNullable(deletePostconditionResult);
+        case READY -> Optional.ofNullable(readyPostconditionResult);
+        case RECONCILE -> Optional.ofNullable(reconcilePostconditionResult);
+      };
+    }
+
     public boolean isReady() {
       return readyPostconditionResult == null || readyPostconditionResult.isSuccess();
     }

operator-framework-core/src/main/java/io/javaoperatorsdk/operator/processing/dependent/workflow/WorkflowReconcileExecutor.java

@@ -255,7 +255,6 @@ private void markDependentsForDelete(
     if (activationConditionMet) {
       // make sure we register the dependent's event source if it hasn't been added already
       // this might be needed in corner cases such as
-      // https://github.com/operator-framework/java-operator-sdk/issues/3249
       registerOrDeregisterEventSourceBasedOnActivation(true, dependentResourceNode);
       createOrGetResultFor(dependentResourceNode).markForDelete();
       if (dependents.isEmpty()) {
@@ -264,11 +263,11 @@ private void markDependentsForDelete(
         dependents.forEach(d -> markDependentsForDelete(d, bottomNodes));
       }
     } else {
-      // this is for an edge case when there is only one resource but that is not active
-      createOrGetResultFor(dependentResourceNode).markAsVisited();
       if (dependents.isEmpty()) {
+        createOrGetResultFor(dependentResourceNode).markAsVisited();
         handleNodeExecutionFinish(dependentResourceNode);
       } else {
+        createOrGetResultFor(dependentResourceNode).markForDelete();
         dependents.forEach(d -> markDependentsForDelete(d, bottomNodes));
       }
     }