Skip to content

Commit 7a06ba8

Browse files
committed
improve: doc fixes for micrometer metrics
Signed-off-by: Attila Mészáros <a_meszaros@apple.com>
1 parent 944f5b1 commit 7a06ba8

File tree

2 files changed

+4
-5
lines changed

2 files changed

+4
-5
lines changed

.github/workflows/e2e-test.yml

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -6,15 +6,14 @@ on:
66
paths-ignore:
77
- 'docs/**'
88
- 'adr/**'
9-
branches: [ main, next, v5.3 ]
9+
branches: [ main, next ]
1010
push:
1111
paths-ignore:
1212
- 'docs/**'
1313
- 'adr/**'
1414
branches:
1515
- main
1616
- next
17-
- v5.3
1817

1918
jobs:
2019
sample_operators_tests:

docs/content/en/docs/documentation/observability.md

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -88,22 +88,22 @@ The simplest way to create an instance:
8888

8989
```java
9090
MeterRegistry registry; // initialize your registry implementation
91-
Metrics metrics = MicrometerMetricsV2.newMicrometerMetricsV2Builder(registry).build();
91+
Metrics metrics = MicrometerMetricsV2.newBuilder(registry).build();
9292
```
9393

9494
Optionally, include a `namespace` tag on per-reconciliation counters (disabled by default to avoid unexpected
9595
cardinality increases in existing deployments):
9696

9797
```java
98-
Metrics metrics = MicrometerMetricsV2.newMicrometerMetricsV2Builder(registry)
98+
Metrics metrics = MicrometerMetricsV2.newBuilder(registry)
9999
.withNamespaceAsTag()
100100
.build();
101101
```
102102

103103
You can also supply a custom timer configuration for `reconciliations.execution.duration`:
104104

105105
```java
106-
Metrics metrics = MicrometerMetricsV2.newMicrometerMetricsV2Builder(registry)
106+
Metrics metrics = MicrometerMetricsV2.newBuilder(registry)
107107
.withExecutionTimerConfig(builder -> builder.publishPercentiles(0.5, 0.95, 0.99))
108108
.build();
109109
```

0 commit comments

Comments
 (0)