wip

Signed-off-by: Attila Mészáros <a_meszaros@apple.com>

Author: csviri

migration/src/main/resources/META-INF/rewrite/v5-3-migration.yml

@@ -70,6 +70,10 @@ recipeList:
       methodPattern: "io.javaoperatorsdk.operator.api.monitoring.Metrics reconciliationExecutionFinished(..)"
       newMethodName: reconciliationSucceeded
       matchOverrides: true
+  - org.openrewrite.java.AddNullMethodArgument:
+      methodPattern: "io.javaoperatorsdk.operator.api.monitoring.Metrics failedReconciliation(..)"
+      argumentIndex: 1
+      parameterType: io.javaoperatorsdk.operator.api.reconciler.RetryInfo
   - org.openrewrite.java.ChangeMethodName:
       methodPattern: "io.javaoperatorsdk.operator.api.monitoring.Metrics failedReconciliation(..)"
       newMethodName: reconciliationFailed
@@ -79,6 +83,10 @@ recipeList:
       parameterType: io.javaoperatorsdk.operator.api.reconciler.RetryInfo
       parameterName: retryInfo
       parameterIndex: 1
+  - org.openrewrite.java.AddNullMethodArgument:
+      methodPattern: "io.javaoperatorsdk.operator.api.monitoring.Metrics finishedReconciliation(..)"
+      argumentIndex: 1
+      parameterType: io.javaoperatorsdk.operator.api.reconciler.RetryInfo
   - org.openrewrite.java.ChangeMethodName:
       methodPattern: "io.javaoperatorsdk.operator.api.monitoring.Metrics finishedReconciliation(..)"
       newMethodName: reconciliationFinished

migration/src/test/java/io/javaoperatorsdk/operator/migration/V53MigrationTest.java

@@ -279,6 +279,73 @@ default void reconciliationFinished(Object resource, RetryInfo retryInfo, Map<St
             """));
   }
 
+  @Test
+  void addsNullRetryInfoArgumentToInvocations() {
+    rewriteRun(
+        // Stub for the Metrics interface with old method names
+        // language=java
+        java(
+            """
+            package io.javaoperatorsdk.operator.api.monitoring;
+
+            import java.util.Map;
+
+            public interface Metrics {
+              default void failedReconciliation(Object resource, Exception exception, Map<String, Object> metadata) {}
+              default void finishedReconciliation(Object resource, Map<String, Object> metadata) {}
+            }
+            """,
+            """
+            package io.javaoperatorsdk.operator.api.monitoring;
+
+            import io.javaoperatorsdk.operator.api.reconciler.RetryInfo;
+
+            import java.util.Map;
+
+            public interface Metrics {
+                default void reconciliationFailed(Object resource, RetryInfo retryInfo, Exception exception, Map<String, Object> metadata) {}
+
+                default void reconciliationFinished(Object resource, RetryInfo retryInfo, Map<String, Object> metadata) {}
+            }
+            """),
+        // Stub for RetryInfo
+        // language=java
+        java(
+            """
+            package io.javaoperatorsdk.operator.api.reconciler;
+            public interface RetryInfo {}
+            """),
+        // Class that calls the old methods
+        // language=java
+        java(
+            """
+            package com.example;
+
+            import java.util.Map;
+            import io.javaoperatorsdk.operator.api.monitoring.Metrics;
+
+            public class MetricsCaller {
+              public void report(Metrics metrics, Object resource, Exception ex, Map<String, Object> meta) {
+                metrics.failedReconciliation(resource, ex, meta);
+                metrics.finishedReconciliation(resource, meta);
+              }
+            }
+            """,
+            """
+            package com.example;
+
+            import java.util.Map;
+            import io.javaoperatorsdk.operator.api.monitoring.Metrics;
+
+            public class MetricsCaller {
+              public void report(Metrics metrics, Object resource, Exception ex, Map<String, Object> meta) {
+                metrics.reconciliationFailed(resource, null, ex, meta);
+                metrics.reconciliationFinished(resource, null, meta);
+              }
+            }
+            """));
+  }
+
   @Test
   void relocatesResourceActionImport() {
     rewriteRun(