wip

Signed-off-by: Attila Mészáros <a_meszaros@apple.com>

Author: csviri

operator-framework-core/src/main/java/io/javaoperatorsdk/operator/processing/event/source/informer/InformerEventSource.java

@@ -194,7 +194,7 @@ private synchronized void onAddOrUpdate(
   }
 
   private boolean canSkipEvent(R newObject, R oldObject, ResourceID resourceID) {
-    return temporaryResourceCache.isNewerThenKnownResource(newObject, resourceID);
+    return !temporaryResourceCache.isNewerThenKnownResource(newObject, resourceID);
     //    if (res.isEmpty()) {
     //      return false;
     //    }

operator-framework-core/src/test/java/io/javaoperatorsdk/operator/processing/event/source/informer/InformerEventSourceTest.java

@@ -95,8 +95,7 @@ public synchronized void start() {}
 
   @Test
   void skipsEventPropagationIfResourceWithSameVersionInResourceCache() {
-    when(temporaryResourceCacheMock.getResourceFromCache(any()))
-        .thenReturn(Optional.of(testDeployment()));
+    when(temporaryResourceCacheMock.isNewerThenKnownResource(any(), any())).thenReturn(false);
 
     informerEventSource.onAdd(testDeployment());
     informerEventSource.onUpdate(testDeployment(), testDeployment());
@@ -106,13 +105,15 @@ void skipsEventPropagationIfResourceWithSameVersionInResourceCache() {
 
   @Test
   void processEventPropagationWithoutAnnotation() {
+    when(temporaryResourceCacheMock.isNewerThenKnownResource(any(), any())).thenReturn(true);
     informerEventSource.onUpdate(testDeployment(), testDeployment());
 
     verify(eventHandlerMock, times(1)).handleEvent(any());
   }
 
   @Test
   void processEventPropagationWithIncorrectAnnotation() {
+    when(temporaryResourceCacheMock.isNewerThenKnownResource(any(), any())).thenReturn(true);
     informerEventSource.onAdd(
         new DeploymentBuilder(testDeployment())
             .editMetadata()
@@ -127,8 +128,7 @@ void processEventPropagationWithIncorrectAnnotation() {
   void propagateEventAndRemoveResourceFromTempCacheIfResourceVersionMismatch() {
     Deployment cachedDeployment = testDeployment();
     cachedDeployment.getMetadata().setResourceVersion(PREV_RESOURCE_VERSION);
-    when(temporaryResourceCacheMock.getResourceFromCache(any()))
-        .thenReturn(Optional.of(cachedDeployment));
+    when(temporaryResourceCacheMock.isNewerThenKnownResource(any(), any())).thenReturn(true);
 
     informerEventSource.onUpdate(cachedDeployment, testDeployment());
 

operator-framework-core/src/test/java/io/javaoperatorsdk/operator/processing/event/source/informer/TemporaryPrimaryResourceCacheTest.java

@@ -66,7 +66,7 @@ void updateAddsTheResourceIntoCacheIfTheInformerHasThePreviousResourceVersion()
   void updateNotAddsTheResourceIntoCacheIfTheInformerHasOtherVersion() {
     var testResource = testResource();
     var informerCachedResource = testResource();
-    informerCachedResource.getMetadata().setResourceVersion("x");
+    informerCachedResource.getMetadata().setResourceVersion("2");
     when(informerEventSource.get(any())).thenReturn(Optional.of(informerCachedResource));
 
     temporaryResourceCache.putResource(testResource, "0");