Skip to content

Commit b9cfe13

Browse files
metacosmcsviri
andauthored
improve: informer health check should not rely on isWatching (#3209) (#3395)
Signed-off-by: Attila Mészáros <a_meszaros@apple.com> Co-authored-by: Attila Mészáros <a_meszaros@apple.com>
1 parent 21c735d commit b9cfe13

1 file changed

Lines changed: 3 additions & 5 deletions

File tree

  • operator-framework-core/src/main/java/io/javaoperatorsdk/operator/processing/event/source/informer

operator-framework-core/src/main/java/io/javaoperatorsdk/operator/processing/event/source/informer/InformerWrapper.java

Lines changed: 3 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -217,16 +217,14 @@ public boolean isRunning() {
217217

218218
@Override
219219
public Status getStatus() {
220-
var status = isRunning() && hasSynced() && isWatching() ? Status.HEALTHY : Status.UNHEALTHY;
220+
var status = isRunning() && hasSynced() ? Status.HEALTHY : Status.UNHEALTHY;
221221
log.debug(
222-
"Informer status: {} for type: {}, namespace: {}, details [is running: {}, has synced: {},"
223-
+ " is watching: {}]",
222+
"Informer status: {} for type: {}, namespace: {}, details [is running: {}, has synced: {}]",
224223
status,
225224
informer.getApiTypeClass().getSimpleName(),
226225
namespaceIdentifier,
227226
isRunning(),
228-
hasSynced(),
229-
isWatching());
227+
hasSynced());
230228
return status;
231229
}
232230

0 commit comments

Comments
 (0)