Address review comments on BulkActivationConditionIT

- Make lastError and callCount instance fields on the reconciler; hold
  the reconciler instance as a static field in the IT so tests can
  access state without static leakage between tests
- Add callCount so the test can wait for any reconciliation activity
  (reconcile() or updateErrorStatus()) then assert cleanly, rather than
  timing out if the bug is fixed
- Add @disabled linking to issue #3249 so this reproducer-only test
  does not break CI
- Add @sample annotation to match the pattern of other workflow ITs

Assisted-by: Claude Sonnet 4.6 <noreply@anthropic.com>
Signed-off-by: Sam Barker <sam@quadrocket.co.uk>

Author: SamBarker

operator-framework/src/test/java/io/javaoperatorsdk/operator/workflow/bulkactivationcondition/BulkActivationConditionIT.java

@@ -18,10 +18,12 @@
 import java.time.Duration;
 
 import org.junit.jupiter.api.BeforeEach;
+import org.junit.jupiter.api.Disabled;
 import org.junit.jupiter.api.Test;
 import org.junit.jupiter.api.extension.RegisterExtension;
 
 import io.fabric8.kubernetes.api.model.ObjectMetaBuilder;
+import io.javaoperatorsdk.annotation.Sample;
 import io.javaoperatorsdk.operator.junit.LocallyRunOperatorExtension;
 import io.javaoperatorsdk.operator.processing.event.NoEventSourceForClassException;
 
@@ -39,25 +41,37 @@
  *   └── SecretBulkDependentResource  (activationCondition = AlwaysTrueActivation)
  * </pre>
  *
- * <p>On first reconciliation with only a primary resource present: the ConfigMap precondition fails
- * → JOSDK calls markDependentsForDelete() → NodeDeleteExecutor fires for SecretBulkDependent →
+ * <p>On first reconciliation the ConfigMap precondition fails → JOSDK calls
+ * markDependentsForDelete() → NodeDeleteExecutor fires for SecretBulkDependent →
  * SecretBulkDependent.getSecondaryResources() calls eventSourceRetriever.getEventSourceFor() → the
  * Secret event source was never registered (NodeReconcileExecutor never ran) →
  * NoEventSourceForClassException.
  *
  * <p>This test FAILS on unfixed JOSDK, demonstrating the bug.
  */
+@Disabled("Reproducer for https://github.com/operator-framework/java-operator-sdk/issues/3249")
+@Sample(
+    tldr = "Bulk Dependent Resource with Activation Condition Bug Reproducer",
+    description =
+        """
+        Reproducer for a bug where NodeDeleteExecutor fires for a BulkDependentResource \
+        with an activationCondition before its event source has been registered, \
+        causing NoEventSourceForClassException. Triggered when a parent dependent \
+        has a failing reconcilePrecondition on first reconciliation.
+        """)
 public class BulkActivationConditionIT {
 
+  static final BulkActivationConditionReconciler reconciler =
+      new BulkActivationConditionReconciler();
+
   @RegisterExtension
   static LocallyRunOperatorExtension extension =
-      LocallyRunOperatorExtension.builder()
-          .withReconciler(new BulkActivationConditionReconciler())
-          .build();
+      LocallyRunOperatorExtension.builder().withReconciler(reconciler).build();
 
   @BeforeEach
-  void resetError() {
-    BulkActivationConditionReconciler.lastError.set(null);
+  void reset() {
+    reconciler.lastError.set(null);
+    reconciler.callCount.set(0);
   }
 
   @Test
@@ -70,21 +84,16 @@ void nodeDeleteExecutorShouldNotThrowWhenEventSourceNotYetRegistered() {
             .build());
     extension.create(primary);
 
-    // Wait for the error to arrive — the ConfigMap precondition always fails,
-    // so JOSDK should attempt NodeDeleteExecutor for the Secret bulk dependent.
-    await()
-        .atMost(Duration.ofSeconds(30))
-        .until(() -> BulkActivationConditionReconciler.lastError.get() != null);
+    // Wait for reconcile() or updateErrorStatus() to be called — whichever comes first.
+    // If the bug is present, updateErrorStatus() fires (no reconcile() call); if fixed,
+    // reconcile() runs cleanly.
+    await().atMost(Duration.ofSeconds(30)).until(() -> reconciler.callCount.get() > 0);
 
-    // On unfixed JOSDK this fails: lastError is a NoEventSourceForClassException (or wraps one).
-    // The assertion below demonstrates the bug by asserting the exception should NOT be present.
-    Exception error = BulkActivationConditionReconciler.lastError.get();
-    assertThat(error)
+    // On unfixed JOSDK this fails: lastError contains NoEventSourceForClassException.
+    assertThat(reconciler.lastError.get())
         .as(
             "NodeDeleteExecutor must not throw NoEventSourceForClassException when the"
-                + " activationCondition-gated event source was never registered."
-                + " Actual error: %s",
-            error)
+                + " activationCondition-gated event source was never registered")
         .satisfies(
             e -> {
               Throwable t = e;

operator-framework/src/test/java/io/javaoperatorsdk/operator/workflow/bulkactivationcondition/BulkActivationConditionReconciler.java

@@ -15,6 +15,7 @@
  */
 package io.javaoperatorsdk.operator.workflow.bulkactivationcondition;
 
+import java.util.concurrent.atomic.AtomicInteger;
 import java.util.concurrent.atomic.AtomicReference;
 
 import io.javaoperatorsdk.operator.api.reconciler.*;
@@ -47,12 +48,17 @@
 public class BulkActivationConditionReconciler
     implements Reconciler<BulkActivationConditionCustomResource> {
 
-  static final AtomicReference<Exception> lastError = new AtomicReference<>();
+  /** Tracks how many times reconcile() or updateErrorStatus() has been called. */
+  final AtomicInteger callCount = new AtomicInteger();
+
+  /** Set when updateErrorStatus() is invoked; null means no error occurred. */
+  final AtomicReference<Exception> lastError = new AtomicReference<>();
 
   @Override
   public UpdateControl<BulkActivationConditionCustomResource> reconcile(
       BulkActivationConditionCustomResource primary,
       Context<BulkActivationConditionCustomResource> context) {
+    callCount.incrementAndGet();
     return UpdateControl.noUpdate();
   }
 
@@ -62,6 +68,7 @@ public ErrorStatusUpdateControl<BulkActivationConditionCustomResource> updateErr
       Context<BulkActivationConditionCustomResource> context,
       Exception e) {
     lastError.set(e);
+    callCount.incrementAndGet();
     return ErrorStatusUpdateControl.noStatusUpdate();
   }
 }