Skip to content

Commit f59d07b

Browse files
committed
wip
Signed-off-by: Attila Mészáros <a_meszaros@apple.com>
1 parent c001f86 commit f59d07b

File tree

1 file changed

+6
-2
lines changed

1 file changed

+6
-2
lines changed

micrometer-support/src/main/java/io/javaoperatorsdk/operator/monitoring/micrometer/MicrometerMetricsV2.java

Lines changed: 6 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -62,6 +62,8 @@ public class MicrometerMetricsV2 implements Metrics {
6262

6363
public static final String RECONCILIATION_EXECUTION_DURATION =
6464
RECONCILIATIONS + "execution.duration";
65+
public static final String NO_NAMESPACE = "NO_NAMESPCAVE";
66+
public static final String UNKNOWN_ACTION = "UNKNOWN";
6567

6668
private final MeterRegistry registry;
6769
private final Map<String, AtomicInteger> gauges = new ConcurrentHashMap<>();
@@ -177,10 +179,10 @@ public void eventReceived(Event event, Map<String, Object> metadata) {
177179
} else {
178180
incrementCounter(
179181
EVENTS_RECEIVED,
180-
"NO_NAMESPACE",
182+
null,
181183
metadata,
182184
Tag.of(EVENT, event.getClass().getSimpleName()),
183-
Tag.of(ACTION, "UNKNOWN"));
185+
Tag.of(ACTION, UNKNOWN_ACTION));
184186
}
185187
}
186188

@@ -250,6 +252,8 @@ private static void addControllerNameTag(String name, List<Tag> tags) {
250252
private void addNamespaceTag(String namespace, List<Tag> tags) {
251253
if (includeNamespaceTag && namespace != null && !namespace.isBlank()) {
252254
addTag(NAMESPACE, namespace, tags);
255+
} else {
256+
addTag(NAMESPACE, NO_NAMESPACE, tags);
253257
}
254258
}
255259

0 commit comments

Comments
 (0)