Merged
Conversation
csviri
changed the title
csviri
changed the title
xstefank
approved these changes
Mar 10, 2025
Collaborator
xstefank
left a comment
xstefank
left a comment
There was a problem hiding this comment.
OK, but isn't this potentially breaking change?
Collaborator
Author
Not really, it is a bit change in the behavior, but rather the previous one was confusing. |
metacosm
requested changes
Mar 10, 2025
...vaoperatorsdk/operator/processing/dependent/workflow/KubernetesResourceDeletedCondition.java
Show resolved
Hide resolved
Signed-off-by: Attila Mészáros <a_meszaros@apple.com>
csviri
force-pushed
the
logging-resource-delete-condition
branch
from
82c5559 to
76819d5
Compare
metacosm
approved these changes
Mar 11, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This way it is easier to reason about the resource deletion.
Signed-off-by: Attila Mészáros a_meszaros@apple.com